Bug 1704924

Summary: python-pynacl FTBFS with hypothesis 4
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-pynaclAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: igor.raits
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-02 23:52:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1686977    
Attachments:
Description Flags
Full log from Copr none

Description Miro Hrončok 2019-04-30 19:32:52 UTC 
Created attachment 1560498 [details]
Full log from Copr

python-pynacl-1.3.0-2.fc31:

+ py.test-2 -v
============================= test session starts ==============================
platform linux2 -- Python 2.7.16, pytest-4.4.1, py-1.8.0, pluggy-0.9.0 -- /usr/bin/python2
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/builddir/build/BUILD/pynacl-1.3.0/.hypothesis/examples')
rootdir: /builddir/build/BUILD/pynacl-1.3.0
plugins: hypothesis-4.9.0
collecting ... collected 4582 items / 2 errors / 4580 selected

==================================== ERRORS ====================================
___________________ ERROR collecting tests/test_bindings.py ____________________
tests/test_bindings.py:310: in <module>
    max_size=2049),
E   TypeError: binary() got an unexpected keyword argument 'average_size'
______________________ ERROR collecting tests/test_box.py ______________________
tests/test_box.py:21: in <module>
    from test_bindings import _box_from_seed_vectors
/usr/lib/python2.7/site-packages/_pytest/assertion/rewrite.py:299: in load_module
    six.exec_(co, mod.__dict__)
/usr/lib/python2.7/site-packages/six.py:709: in exec_
    exec("""exec _code_ in _globs_, _locs_""")
<string>:1: in <module>
    ???
tests/test_bindings.py:310: in <module>
    max_size=2049),
E   TypeError: binary() got an unexpected keyword argument 'average_size'
=============================== warnings summary ===============================
/usr/lib/python2.7/site-packages/hypothesis/_settings.py:193
  /usr/lib/python2.7/site-packages/hypothesis/_settings.py:193: HypothesisDeprecationWarning: The timeout setting can safely be removed with no effect.
    verbosity=self.verbosity,

-- Docs: https://docs.pytest.org/en/latest/warnings.html
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
===================== 1 warnings, 2 error in 4.75 seconds ======================

This blocks the Python 3.8 rebuild.

Full log attached.
Comment 1 Miro Hrončok 2019-05-02 23:37:55 UTC 
This blocks ansible, so I'm gonna look into it.
Comment 2 Miro Hrončok 2019-05-02 23:44:40 UTC 
It appears to be caused by a hypothesis update, not pytest.

Upstream fix: https://github.com/pyca/pynacl/pull/480

Running a scratchbuild.
Comment 3 Miro Hrončok 2019-05-02 23:52:09 UTC 
it builds. Added the patch to git.