Bug 1705513

Summary: Review Request: perl-Role-Commons - Roles that can be commonly used
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Role-Commons-0.104-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-03 14:07:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-05-02 12:41:04 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Role-Commons/perl-Role-Commons.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Role-Commons/perl-Role-Commons-0.104-1.fc31.src.rpm
Description:
Role-Commons is not yet another implementation of roles. It is a collection of
generic, reusable roles that hopefully you will love to apply to your classes.
These roles are built using Moo::Role, so automatically integrate into the
Moose object system if you're using it, but they do not require Moose.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2019-05-03 08:12:39 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Role-Commons-0.104-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(match::simple)
      1 perl(:MODULE_COMPAT_5.28.2)
      1 perl(Module::Runtime)
      1 perl(Moo::Role)
      1 perl(Object::ID)
      1 perl(Role::Commons)
      1 perl(Role::Commons::Authority)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Types::TypeTiny) >= 1.000000
      1 perl(:VERSION) >= 5.6.0
      1 perl(:VERSION) >= 5.8.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Role-Commons-0.104-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(Object::AUTHORITY) = 0.104
      1 perl(Role::Commons) = 0.104
      1 perl-Role-Commons = 0.104-1.fc31
      1 perl(Role::Commons::Authority) = 0.104
      1 perl(Role::Commons::ObjectID) = 0.104
      1 perl(Role::Commons::Tap) = 0.104
Binary provides are Ok.

$ rpmlint ./perl-Role-Commons*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Resolution:
Approved
Comment 2 Gwyn Ciesla 2019-05-03 13:42:24 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Role-Commons
Comment 3 Petr Pisar 2019-05-03 14:07:16 UTC 
Thank you for the review and the repository.