Bug 170570
| Summary: | gdm doesn't write to btmp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Grubb <sgrubb> | ||||
| Component: | gdm | Assignee: | Ray Strode [halfline] <rstrode> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Mike McLean <mikem> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | james.antill | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-07-19 18:40:35 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 150223 | ||||||
| Attachments: |
|
||||||
|
Description
Steve Grubb
2005-10-12 22:15:31 UTC
Created attachment 128198 [details]
add btmp logging, first cut
This is my first "it works for me" cut of the btmp logging. There are a few
things I know about (feel free to let me know what you think):
. Patch is against 2.14.0-1
. Hostname logging untested (same as "audit" though).
. Later pam failures untested (dito).
.. Note that audit doesn't get the username when the passwd is wrong though,
so should probably trust it about as far as we can throw it.
. did_setcred path (last possible failure) might well not be correct.
. If using "selected_user" (face browser?) ... then bad passwd's aren't logged
in btmp or audit.
. HAVE_UPDWTMP and _HAVE_UT_TV probably need to be in autoconf.
. Might want to move entire logbtmp() function to another file, so as to keep
utmp.h namespace from current file.
Thanks James, This looks pretty good as a first cut. I'm in the process of rewriting some of the PAM code in GDM right now, so as I'm working on that I'll fold this in. So what's the status on this? We are losing valuable testing time. It didn't make test1, it will definitely make test2. I've integrated btmp (and wtmp so we can ditch calling /usr/bin/sessreg) logging support into the PAM code rewrite. It's not ready to comitted yet, however. I'll post an update when the patch lands in rawhide. The PAM requires some changes to GDM that won't be done by RHEL-5, so I implemented this functionality separately in the mean time. |