Bug 1706000

Summary:	OCS upgrade playbook does not do a health check for heketi and glusterblock provisioner pod after upgrade
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Ashmitha Ambastha <asambast>
Component:	cns-ansible	Assignee:	Jose A. Rivera <jarrpa>
Status:	CLOSED NOTABUG	QA Contact:	Ashmitha Ambastha <asambast>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	ocs-3.11	CC:	hchiramm, kramdoss, madam, rhs-bugs, sankarshan, sarumuga
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-06 13:18:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1703695

Description Ashmitha Ambastha 2019-05-03 11:39:42 UTC

Description of problem:
After the upgrade of all the pods is performed, the upgrade playbook should check the health of the heketi and glusterblock provisioner pod and only then pass the playbook run. It should fail if all OCS pods are unhealthy.

Version-Release number of selected component (if applicable): OCS 3.11


How reproducible: always


Steps to Reproduce:
1. Deploy a cluster to be upgraded. 
2. Run IOs on the cluster before performing an upgrade using the upgrade playbook. 
3. Run the upgrade playbook, 
# ansible-playbook -i <inv_file> /usr/share/ansible/openshift-ansible/playbooks/openshift-glusterfs/upgrade.yml 
4. If the health of heketi and glusterblock provisioner pod is not 1/1 and Running state, the playbook should fail. 
5. If the health of heketi and glusterblock provisioner pod is 1/1 and Running state, the playbook should pass. 

Actual results: The upgrade playbook doesn't check the heketi and glusterblock provisisoner pod health once upgrading successfully. 


Expected results: The upgrade playbook should check the heketi and glusterblock provisisoner pod health once upgrading successfully.

Comment 2 Jose A. Rivera 2019-05-06 13:18:11 UTC

This is already taken care of.

heketi: https://github.com/openshift/openshift-ansible/blob/release-3.11/roles/openshift_storage_glusterfs/tasks/heketi_deploy.yml#L58-L70

glusterblock-provisioner: https://github.com/openshift/openshift-ansible/blob/release-3.11/roles/openshift_storage_glusterfs/tasks/glusterblock_deploy.yml#L28-L40

Both tasks do not succeed until a pod is found that is "Ready".

Closing this as NOTABUG.