Bug 1706489

Summary:	blscfg sets wrong value for gfxpayload
Product:	[Fedora] Fedora	Reporter:	Tom Porter <tomporterjr>
Component:	grub2	Assignee:	Peter Jones <pjones>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	30	CC:	fedora, fmartine, lkundrak, pjones
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	grub2-2.02-84.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-28 01:03:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom Porter 2019-05-05 04:36:20 UTC

Description of problem:
BIOS boot does NOT result in high res, plymouth splash. Upon inspecting the loader entry (via e key), a line reads set gfx_payload=keep. Because it is not gfxpayload=keep (without the underscore), my BIOS boot drops to the standard, low res, text console after the grub menu. If I manually edit the grub entry, during boot and remove the underscore (_), graphical/splash booting occurs because the gfxpayload has been kept.

Version-Release number of selected component (if applicable):
2.02-78.fc30

How reproducible:
Very (on my system)

Steps to Reproduce:
1. Use blscfg
2. Set a sufficient resolution in /etc/default/grub
3. Make the config
4. BIOS boot

Actual results:
plymouth drops to low res, text splash

Expected results:
plymouth to use higher res, fb splash

Additional info:

Comment 1 Christian Stadelmann 2019-10-15 17:45:36 UTC

@fmartine: Can you please also fix this issue on Fedora 30 and 31?

Comment 2 Javier Martinez Canillas 2019-10-16 08:39:52 UTC

(In reply to Christian Stadelmann from comment #1)
> @fmartine: Can you please also fix this issue on Fedora 30 and 31?

Sure, I'll backport the fix to both F30 and F31.

Comment 3 Fedora Update System 2019-10-16 10:50:36 UTC

FEDORA-2019-9c4324f599 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9c4324f599

Comment 4 Javier Martinez Canillas 2019-10-16 10:52:52 UTC

(In reply to Javier Martinez Canillas from comment #2)
> (In reply to Christian Stadelmann from comment #1)
> > @fmartine: Can you please also fix this issue on Fedora 30 and 31?
> 
> Sure, I'll backport the fix to both F30 and F31.

Pushed an update for F30, will do the same for F31 after is released since we are in the freeze now.

Comment 5 Fedora Update System 2019-10-16 16:05:21 UTC

grub2-2.02-84.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9c4324f599

Comment 6 Fedora Update System 2019-10-28 01:03:40 UTC

grub2-2.02-84.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Tom Porter 2019-11-08 23:04:40 UTC

Once installing the update, are there additional steps required? I have 2 Fedora 30 systems, one EFI, one Legacy. On the EFI boot system, the value is reflected properly, i.e. the underscore has been removed. On the Legacy system, the underscore is still present, though it is running the same version of grub2 as the EFI system. For good measure, I also did a grub2-mkconfig. It didn't alter the value, not that I thought it would.

Comment 8 Tom Porter 2019-11-11 04:52:36 UTC

After doing a bit more digging and searching, this: https://bugzilla.redhat.com/show_bug.cgi?id=1698227 might be related to what I am seeing. Apparently the updated blscfg.mod of grub2-2.02-84.fc30 is not copied into /boot/grub2/i386-pc from /usr/lib/grub/i386-pc. Copying blscfg.mod by hand into the proper /boot location, seems to 'fix' the update not showing. I'm concerned about why this didn't happen and what else might not have updated.

Comment 9 Javier Martinez Canillas 2019-11-11 07:57:48 UTC

(In reply to Tom Porter from comment #8)
> After doing a bit more digging and searching, this:
> https://bugzilla.redhat.com/show_bug.cgi?id=1698227 might be related to what
> I am seeing. Apparently the updated blscfg.mod of grub2-2.02-84.fc30 is not
> copied into /boot/grub2/i386-pc from /usr/lib/grub/i386-pc. Copying
> blscfg.mod by hand into the proper /boot location, seems to 'fix' the update
> not showing. I'm concerned about why this didn't happen and what else might
> not have updated.

Yes, for legacy BIOS installs GRUB is not updated when the package is upgraded. You need to explicitly run grub2-install to update the GRUB core.img and modules.