Bug 170691
Summary: | Review Request: basket - Notes taker for KDE | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Aurelien Bompard <gauret> |
Component: | Package Review | Assignee: | Adrian Reber <adrian> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, rdieter, thomasj |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://basket.kde.org/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-16 21:32:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Aurelien Bompard
2005-10-13 19:41:02 UTC
The package should own "/usr/share/doc/HTML/en/basket/" And I cannot see the icon in the gnome menu. Even after a restart of the menu. Can icons in the crystalsvg be used from the gnome panel? Adrian, IMO, the icon missing is an upstream issue, in that basket should be installing it's icon(s) in the hicolor theme, not crystalsvg. crystalsvg inherits from hicolor, so the quick-n-dirty fix would be to: mv $RPM_BUILD_ROOT%{_datadir}/icons/cyrstalsvg \ $RPM_BUILD_ROOT%{_datadir}/icons/hicolor and then adjust %post/%postun, to something like: %post touch %{_datadir}/icons/hicolor ||: gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: %postun if [ $1 -eq 0 ]; then touch %{_datadir}/icons/hicolor ||: gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: fi Interestingly, I just looked at /usr/share/icons/Bluecurve/index.theme, and it includes: Bluecurve/index.theme:Inherits=gnome,crystalsvg so it *should* have inherited from cyrstalsvg too. ??? Adrian, what icon theme are you using? However, I'd still recommend using hicolor instead of crystalsvg, since all(most?) icon themes should (eventually) inherit from it (which isn't necesarily true for crystalsvg). Thanks for the review. http://gauret.free.fr/fichiers/rpms/fedora/basket-0.5.0-2.src.rpm * Fri Oct 14 2005 Aurelien Bompard <gauret[AT]free.fr> 0.5.0-2 - own the doc dir - use hicolor instead of crystalsvg as icon theme - add extension to the icon in the desktop file I've change the icon entry in the desktop file from "basket" to "basket.png". IIRC, GNOME needs the extension. Does the icon show up in GNOME now ? Having to add the .png is unfortunate, which now makes kde unable to use basket's scalable svg icon: %_datadir/icons/(hicolor|crystalsvg)/scalable/apps/basket.svg Just checked the icon spec, http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html you shouldn't need to add the .png extension. Implementations are supposed to automatically search for png, svg(optional), and xpm icons. You should also "touch" the top-level icon dir (to update it's mtime) per comment #2, per the Icon spec (appended). To be safe (especially if the icon theme dir ever changes), you can ignore my suggested: %postun if [ $1 -eq 0 ]; bit, so the touch and gtk-update-... runs unconditionally. ----------------- ... any implementation that does caching is required to look at the mtime of the toplevel icon directories when doing a cache lookup, unless it already did so less than 5 seconds ago. This means that any icon editor or theme installation program need only to change the mtime of the the toplevel directory where it changed the theme to make sure that the new icons will eventually get used. ----------------- I tried in GNOME with the .png extension, and it didn't change a thing, so I removed the hack. http://gauret.free.fr/fichiers/rpms/fedora/basket-0.5.0-2.src.rpm * Fri Oct 14 2005 Aurelien Bompard <gauret[AT]free.fr> 0.5.0-3 - don't add the extension to the icon, it's useless - touch the icon dir in post and postun Does the icon show up in GNOME ? At some point I tried a symlink to /usr/share/pixmaps, and the icon appeared. Then I removed the symlink, and now the icons stays (tried to restart GNOME, still there). What's the preferred way ? Wrong URL, it should be release 3 : http://gauret.free.fr/fichiers/rpms/fedora/basket-0.5.0-3.src.rpm I can see the icon now. * builds in mock * clean installation and removal * source matches upstream * scripts look sane * spec looks good * rpmlint has two warnings: W: basket dangling-symlink /usr/share/doc/HTML/en/basket/common /usr/share/doc/HTML/en/common W: basket symlink-should-be-relative /usr/share/doc/HTML/en/basket/common /usr/share/doc/HTML/en/common I have seen that other KDE related packages have the same warning with rpmlint so I suppose this isn't a big problem. It doesn't also sound as if it is a big problem. APPROVED Package Change Request ====================== Package Name: basket New Branches: EL-4 EL-5 EL-6 Owners: thomasj Let's use a shorter route ( implicit approval for the below request change was given by Thomas via Email; I am removing EL-4 from the list because I can not perform tests which imply desktop-like software on this platform ): Package Change Request ====================== Package Name: basket New Branches:EL-5 EL-6 Owners: thomasj InitialCC: wolfy Yes, the above is fine with me. cvs done. |