Bug 1707059

Summary:	no termination message provided by failing cluster-storage-operator pod
Product:	OpenShift Container Platform	Reporter:	Luis Sanchez <sanchezl>
Component:	Storage	Assignee:	Bradley Childs <bchilds>
Status:	CLOSED ERRATA	QA Contact:	Liang Xia <lxia>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.1.0	CC:	aos-bugs, aos-storage-staff, bbennett, chaoyang, fbertina, lxia, mifiedle, sejug
Target Milestone:	---
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1707050	Environment:
Last Closed:	2019-10-16 06:28:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luis Sanchez 2019-05-06 17:31:26 UTC

The cluster-storage-operator pods do not provide a termination message, hindering debugging efforts when the pods are crash looping.

At minimum, the pod's terminationMessagePolicy should be "FallbackToLogsOnError".

See https://kubernetes.io/docs/tasks/debug-application-cluster/determine-reason-pod-failure/#customizing-the-termination-message

Expected Results:
The termination message should appear in a pod container's  .status.lastState.terminated.message field.

Comment 1 Ben Bennett 2019-05-06 17:42:57 UTC

Pushing this to 4.2.  We could consider a fix in 4.1.z, but it doesn't seem worth blocking 4.1.0 for this.

Comment 2 Matthew Wong 2019-05-06 18:40:23 UTC

PR opened: https://github.com/openshift/cluster-storage-operator/pull/33.

agree it's not a blocker. No risk if we merge it early though.

Comment 6 Liang Xia 2019-06-25 03:44:14 UTC

$ oc get co storage
NAME      VERSION                             AVAILABLE   PROGRESSING   DEGRADED   SINCE
storage   4.2.0-0.nightly-2019-06-24-160709   True        False         False      56m

$ oc get pods -n openshift-cluster-storage-operator -o yaml | grep -i termination
      terminationMessagePath: /dev/termination-log
      terminationMessagePolicy: FallbackToLogsOnError
    terminationGracePeriodSeconds: 30

Comment 7 errata-xmlrpc 2019-10-16 06:28:30 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922