Bug 1707379

Summary:	virt-install with --sysinfo type=random-string silently defaults to smbios
Product:	Red Hat Enterprise Linux 8	Reporter:	Pavel Hrdina <phrdina>
Component:	virt-manager	Assignee:	Pavel Hrdina <phrdina>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.0	CC:	juzhou, mzhan, tzheng, xiaodwan
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-manager-2.2.0-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1707380 (view as bug list)		Environment:
Last Closed:	2019-11-05 21:19:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1707380

Description Pavel Hrdina 2019-05-07 11:56:40 UTC

"virt-install ... --sysinfo foobar" silently defaults to smbios type.
We should pass that value to libvirt and libvirt validate it and error
out if it's incorrect.

Comment 2 Pavel Hrdina 2019-05-15 05:54:19 UTC

Upstream commit:

commit 897578aee2c22cb2aae66cb23cfd8cc8b79c11c5
Author: Pavel Hrdina <phrdina>
Date:   Tue May 14 14:00:18 2019 +0200

    cli: fix sysinfo type parsing

Comment 4 zhoujunqin 2019-07-31 07:52:34 UTC

Reproduce with:
virt-manager-2.0.0-5.el8.noarch
virt-install-2.0.0-5.el8.noarch

Steps:
1. Install a vm with specified a invalid type to "--sysinfo".
# virt-install --name testvm --memory 1024 --boot initargs="none",smbios_mode=sysinfo  --sysinfo foobar  --disk none --debug

Starting install...
...
  <sysinfo type='smbios'/>
  <os>
    <type arch='x86_64' machine='pc-i440fx-rhel7.6.0'>hvm</type>
    <boot dev='hd'/>
    <smbios mode='sysinfo'/>
  </os>

Result: Installation starts successfully with invalid sysinfo type, silently defaults to smbios type.

Verify with:
virt-install-2.2.1-1.el8.noarch
virt-manager-2.2.1-1.el8.noarch
libvirt-4.5.0-30.module+el8.1.0+3574+3a63752b.x86_64
qemu-kvm-2.12.0-82.module+el8.1.0+3738+0d8c0249.x86_64

Steps:
# virt-install --name testvm --memory 1024 --boot initargs="none",smbios_mode=sysinfo  --sysinfo foobar  --disk none 
WARNING  No operating system detected, VM performance may suffer. Specify an OS with --os-variant for optimal results.

Starting install...
ERROR    unsupported configuration: unknown sysinfo type 'foobar'
Domain installation does not appear to have been successful.
If it was, you can restart your domain by running:
  virsh --connect qemu:///system start testvm
otherwise, please restart your installation.


Result: virt-install fails to start with clear error prompts "unsupported configuration: unknown sysinfo type 'foobar'", so I move this bug from ON_QA to VERIFIED.

Comment 6 errata-xmlrpc 2019-11-05 21:19:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3464