Bug 1707514

Summary: Wrong libdir in pkgconfig file
Product: [Fedora] Fedora Reporter: Michael Theall <pigman46>
Component: octomapAssignee: Rich Mattes <richmattes>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 30CC: laurent.rineau__fedora, richmattes, robotics
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: octomap-1.8.1-8.fc30 octomap-1.8.1-6.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-12 01:01:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Theall 2019-05-07 16:58:35 UTC
Description of problem:
octomap.pc contains "libdir=${prefix}/lib" instead of lib64

Version-Release number of selected component (if applicable):
octomap-1.8.1-6.fc30.x86_64


How reproducible:
Always


Steps to Reproduce:
1. install octomap-devel on x86_64
2. pkg-config --libs octomap

Actual results:
-L/usr/lib -loctomap -loctomath


Expected results:
-L/usr/lib64 -loctomap -loctomath


Additional info:
Causes warning messages when compiling such as these:
/usr/bin/ld: skipping incompatible /usr/lib/libpthread.so when searching for -lpthread
/usr/bin/ld: skipping incompatible /usr/lib/libm.so when searching for -lm
/usr/bin/ld: skipping incompatible /usr/lib/libc.so when searching for -lc
It does not cause compilation failure and therefore low priority.

Looks like octomap-1.8.0-libdir.patch in the source rpm fixes a lot of LIB_SUFFIX issues but misses a change in octomap-b8c1d62a7a64ce0a5df278503f31d73acafa97e4/octomap/CMakeModules/InstallPkgConfigFile.cmake

This might be sufficient to fix it:
"libdir=\${prefix}/lib\n" -> "libdir=\${prefix}/lib${LIB_SUFFIX}\n"

Comment 1 Rich Mattes 2019-08-03 19:11:01 UTC
Thanks for the report.  You're right, it looks like I missed that libdir when I fixed the rest of them. I am updating the patch and rebuilding now.

Comment 2 Fedora Update System 2019-08-03 19:43:24 UTC
FEDORA-2019-a1783f0331 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a1783f0331

Comment 3 Fedora Update System 2019-08-03 20:14:57 UTC
FEDORA-2019-cfb65c8bf0 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfb65c8bf0

Comment 4 Fedora Update System 2019-08-04 02:19:33 UTC
octomap-1.8.1-8.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a1783f0331

Comment 5 Fedora Update System 2019-08-04 02:26:39 UTC
octomap-1.8.1-6.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfb65c8bf0

Comment 6 Fedora Update System 2019-08-12 01:01:13 UTC
octomap-1.8.1-8.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2019-08-12 01:39:15 UTC
octomap-1.8.1-6.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.