Bug 1707700

Summary:	maintain consistent values across for options when fetched at cluster level or volume level
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	cli	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	amukherj, bugs, nchilaka, rhinduja, rhs-bugs, sankarshan, srakonde, storage-qa-internal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1706776	Environment:
Last Closed:	2019-05-09 19:37:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1706776

Comment 1 Atin Mukherjee 2019-05-08 06:49:21 UTC

Description of problem:
=====================
A few options are showing different values when they are fetched at cluster level as against volume level.
A consistent representation would be nice to have
eg: 

[root@dhcp42-80 ~]# gluster v get test350 all|egrep "cluster.server-quorum-ratio|cluster.enable-shared-storage|cluster.op-version|cluster.max-op-version|cluster.brick-multiplex|cluster.max-bricks-per-process|glusterd.vol_count_per_thread|cluster.daemon-log-level"
cluster.server-quorum-ratio             0                                       
cluster.enable-shared-storage           disable                                 
cluster.brick-multiplex                 off                                     
glusterd.vol_count_per_thread           100                                     
cluster.max-bricks-per-process          250                                     
cluster.daemon-log-level                INFO                                    
[root@dhcp42-80 ~]# gluster v get all all
Option                                  Value                                   
------                                  -----                                   
cluster.server-quorum-ratio             51                                      
cluster.enable-shared-storage           disable                                 
cluster.op-version                      70000                                   
cluster.max-op-version                  70000                                   
cluster.brick-multiplex                 disable                                 
cluster.max-bricks-per-process          250                                     
glusterd.vol_count_per_thread           100                                     
cluster.daemon-log-level                INFO                                    



In above example below are the descrepencies

1)It can be seen that "cluster.server-quorum-ratio"at cluster level shows 51% as against 0 at volume level
2)  and "cluster.brick-multiplex  " shows disable at cluster level as against off at volume level--> though both are effectively same, it would be good to either use disable or off at both places. No functional impact, and more of a cosmetic issue


Version-Release number of selected component (if applicable):
================
mainline

How reproducible:
================
always

Comment 2 Atin Mukherjee 2019-05-08 06:52:39 UTC

RCA:

There are two places where global cluster wide options are defined. (1) In valid_all_vol_opts structure & (2) In VME table in glusterd-volume-set.c . In 1 & 2 the default values don't match and hence this bug.

Comment 3 Worker Ant 2019-05-08 06:54:53 UTC

REVIEW: https://review.gluster.org/22680 (glusterd: fix inconsistent global option output in volume get) posted (#1) for review on master by Atin Mukherjee

Comment 4 Worker Ant 2019-05-09 19:37:45 UTC

REVIEW: https://review.gluster.org/22680 (glusterd: fix inconsistent global option output in volume get) merged (#2) on master by Amar Tumballi