Bug 1708004

See also https://github.com/pytest-dev/pluggy/issues/209

as the link above implies that seems to be originating from py.test, but SQLAlchemy uses getfullargspec() also internally, not sure if the warning would just move.  getfullargspec() is already a Py3k-only method I had to move from getargspec(), I wish they'd stop changing this.

What bothers me is that a DeprecationWarning renders the entire thing failed :(

so this should be tunable via the warnings filter and possibly a py.test option in setup.cfg. OTOH if pluggy is forcing this to behave this way then they'd have to fix it or fedora needs to patch it.

Let's wait a bit for pluggy upstream response I guess. It's in pytest-dev GitHub org, so if pytest is forcing it, they should know as well.

(In reply to Michael Bayer from comment #2)
> as the link above implies that seems to be originating from py.test, but
> SQLAlchemy uses getfullargspec() also internally, not sure if the warning
> would just move.  getfullargspec() is already a Py3k-only method I had to
> move from getargspec(), I wish they'd stop changing this.

Apparently, you are not alone. If I get this right, this will not be deprecated in 3.8:

https://bugs.python.org/issue36751
https://github.com/python/cpython/pull/13245

Pluggy 0.11.1 will include a fix for this.

Heh, but sqlalchemy has that as well:

Traceback (most recent call last):
  File "/usr/lib64/python3.8/runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib64/python3.8/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/lib/python3.8/site-packages/pytest.py", line 89, in <module>
    raise SystemExit(pytest.main())
  File "/usr/lib/python3.8/site-packages/_pytest/config/__init__.py", line 79, in main
    return config.hook.pytest_cmdline_main(config=config)
  File "/usr/lib/python3.8/site-packages/pluggy/hooks.py", line 296, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/lib/python3.8/site-packages/pluggy/manager.py", line 68, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/lib/python3.8/site-packages/pluggy/manager.py", line 59, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "/usr/lib/python3.8/site-packages/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File "/usr/lib/python3.8/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/usr/lib/python3.8/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/lib/python3.8/site-packages/_pytest/main.py", line 242, in pytest_cmdline_main
    return wrap_session(config, _main)
  File "/usr/lib/python3.8/site-packages/_pytest/main.py", line 234, in wrap_session
    config.hook.pytest_sessionfinish(
  File "/usr/lib/python3.8/site-packages/pluggy/hooks.py", line 296, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/lib/python3.8/site-packages/pluggy/manager.py", line 68, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/lib/python3.8/site-packages/pluggy/manager.py", line 59, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "/usr/lib/python3.8/site-packages/pluggy/callers.py", line 203, in _multicall
    gen.send(outcome)
  File "/usr/lib/python3.8/site-packages/_pytest/terminal.py", line 656, in pytest_sessionfinish
    outcome.get_result()
  File "/usr/lib/python3.8/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/usr/lib/python3.8/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/testing/plugin/pytestplugin.py", line 98, in pytest_sessionfinish
    plugin_base.final_process_cleanup()
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/testing/plugin/plugin_base.py", line 565, in final_process_cleanup
    engines.testing_reaper._stop_test_ctx_aggressive()
  File "<string>", line 2, in _stop_test_ctx_aggressive
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/testing/assertions.py", line 124, in decorate
    return fn(*args, **kw)
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/testing/engines.py", line 97, in _stop_test_ctx_aggressive
    rec.dispose()
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/engine/base.py", line 2014, in dispose
    self.pool = self.pool.recreate()
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/pool/impl.py", line 298, in recreate
    return self.__class__(
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/pool/impl.py", line 290, in __init__
    Pool.__init__(self, creator, **kw)
  File "<string>", line 2, in __init__
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/util/deprecations.py", line 130, in warned
    return fn(*args, **kwargs)
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/pool/base.py", line 202, in __init__
    self._creator = creator
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/pool/base.py", line 238, in _creator
    self._invoke_creator = self._should_wrap_creator(creator)
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/pool/base.py", line 247, in _should_wrap_creator
    argspec = util.get_callable_argspec(self._creator, no_self=True)
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/util/langhelpers.py", line 351, in get_callable_argspec
    return compat.inspect_getfullargspec(fn)
  File "/usr/lib64/python3.8/inspect.py", line 1114, in getfullargspec
    warnings.warn("Use inspect.signature() instead of inspect.getfullargspec()",
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/testing/assertions.py", line 152, in our_warn
    return real_warn(msg, *arg, **kw)
DeprecationWarning: Use inspect.signature() instead of inspect.getfullargspec()

yes see comment #2 as well as https://github.com/sqlalchemy/sqlalchemy/issues/4674

see also https://github.com/sqlalchemy/alembic/issues/563 as people that use SQLAlchemy usually use Alembic as well as https://github.com/sqlalchemy/mako/issues/295 which Alembic uses.

See https://src.fedoraproject.org/rpms/python-tornado/pull-request/5 - that is an example of a probably simplest course of action for a downstream maintainer.

lib/sqlalchemy/testing/warnings.py has:

def setup_filters():
    """Set global warning behavior for the test suite."""

    warnings.filterwarnings(
        "ignore", category=sa_exc.SAPendingDeprecationWarning
    )
    warnings.filterwarnings("error", category=sa_exc.SADeprecationWarning)
    warnings.filterwarnings("error", category=sa_exc.SAWarning)

    # some selected deprecations...
    warnings.filterwarnings("error", category=DeprecationWarning)
    warnings.filterwarnings(
        "ignore", category=DeprecationWarning, message=".*StopIteration"
    )
    warnings.filterwarnings(
        "ignore", category=DeprecationWarning, message=".*inspect.getargspec"
    )

I suppose we can sed s/getargspec/*/ and call it a day.

Testing a build with:

%prep
...
# https://bugzilla.redhat.com/show_bug.cgi?id=1708004
sed -i 's/getargspec//' lib/sqlalchemy/testing/warnings.py


It is enough to make the tests at least run.

yes if you can do that on the package side here, that is your best course right now.

A test failure:

=================================== FAILURES ===================================
_ ComponentReflectionTest_sqlite+pysqlite_3_28_0.test_deprecated_get_primary_keys _
Traceback (most recent call last):
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/testing/suite/test_reflection.py", line 594, in test_deprecated_get_primary_keys
    users.name,
  File "/builddir/build/BUILD/SQLAlchemy-1.3.3/test/../lib/sqlalchemy/testing/assertions.py", line 309, in assert_raises_message
    assert False, "Callable did not raise an exception"
AssertionError: Callable did not raise an exception
=========================== short test summary info ============================


It speaks of deprecation, will check the test code.

It fails even with: sed -i 's/getargspec/get(full)?argspec/' lib/sqlalchemy/testing/warnings.py

For now, upstream has removed the DeprecationWarning. I will do the same and later upload an up to date build.log if it keeps failing.

that test is looking for:

 sa_exc.SADeprecationWarning,
            r".*get_primary_keys\(\) method is deprecated",

> For now, upstream has removed the DeprecationWarning. I will do the same and later upload an up to date build.log if it keeps failing.

All good now. Thank you, Michael.

what a drama.  I'm going to pursue changing getfullargspec() in any case since the one in Python 3 is very slow.