Bug 1708195

Summary:	V2v - convert disk size
Product:	Container Native Virtualization (CNV)	Reporter:	Marek Libra <mlibra>
Component:	User Experience	Assignee:	Marek Libra <mlibra>
Status:	CLOSED ERRATA	QA Contact:	Ilanit Stein <istein>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.0	CC:	cnv-qe-bugs, ibragins, istein, ncredi, rawagner, sgordon, tgolembi
Target Milestone:	---
Target Release:	2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	2.0.0-14.4	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-24 20:15:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marek Libra 2019-05-09 10:59:24 UTC

Related to the Web UI.

Description of problem:
For some source VMWare VMs during v2v, the disk size is computed to a weird floating number (i.e. 9.5123123...) on the Storage wizard step. A PV of such size can not be successfully provisioned (at least not on gluster), so the flow fails.

Version-Release number of selected component (if applicable):
2.0.0

How reproducible:
100% With a proper source VM

Steps to Reproduce:
1. Launch Create VM Wizard, VMWare Import flow
2. Find a source VM with "weird" computed disk size
3. Finish the Wizard, check for error

Actual results:
Disk size is not in format/range acceptable by storage provider.

Expected results:
"Weird" values of storage class are rounded to acceptable value.
Needs to be verified, but it is probably nearest higher integer number.


Additional info:
When fixing the issue, I can help in finding the source VM with such incorrect disk size.

Comment 1 Tomáš Golembiovský 2019-05-10 08:51:34 UTC

Why exactly do you recalculate the size to GB? It should be possible to request PV with specified number of bytes, isn't it? Or are such requirements always present (e.g. provider requires sizes rounded to GBs or block size multiples)?

Comment 2 Marek Libra 2019-05-15 10:41:38 UTC

Prior v2v, the only source for the disk size value was the input from user, which is in GiBs.
We can either change the unit internally used or recalculate.

In the fix I propose, we recalculate to whatever reasonable unit when creating PVC.

Comment 3 Marek Libra 2019-05-15 13:52:29 UTC

Patch: https://github.com/kubevirt/web-ui-components/pull/452

Comment 4 Ilanit Stein 2019-06-04 08:23:02 UTC

Marek,

Can you please help in exact reproduce steps, when using local storage?

Thanks,
Ilanit.

Comment 5 Igor Braginsky 2019-06-17 09:15:19 UTC

Verified fix on version HCO 27.
VM had 2 disks, one usual with OS, second small, 1MB without filesystem.
During migration wizard showed second disk with its proper size.

Comment 7 errata-xmlrpc 2019-07-24 20:15:51 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1850