Bug 1708297

Summary: syncthing should not install its own preset file
Product: [Fedora] Fedora Reporter: Zbigniew Jędrzejewski-Szmek <zbyszek>
Component: syncthingAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 32CC: decathorpe, fedora, go-sig
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: syncthing-1.3.4-2.fc32 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-16 20:20:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1468501    
Bug Blocks:    

Description Zbigniew Jędrzejewski-Szmek 2019-05-09 14:39:13 UTC
Description of problem:
SSIA. /usr/lib/systemd/user-preset/90-syncthing.preset must go.

Version-Release number of selected component (if applicable):
syncthing-0:1.1.1-1.fc30.x86_64

Comment 1 Fabio Valentini 2019-05-09 15:04:54 UTC
Does fedora now include a preset to disable user units by default?

Comment 2 Fabio Valentini 2019-05-09 15:06:15 UTC
I initially included this preset file because without it, syncthing service would be enabled and started for all users, including root, gdm, and others.

Comment 3 Fabio Valentini 2019-05-09 15:10:37 UTC
Now I remember, I reported this issue two years ago, but you already know that.

https://bugzilla.redhat.com/show_bug.cgi?id=1468501

Comment 4 Zbigniew Jędrzejewski-Szmek 2019-05-09 15:12:00 UTC
Yep, I'm about to file a PR for fedora-release ;)

Comment 5 Fabio Valentini 2019-05-09 15:17:40 UTC
Ah, good :)

So, to not break anything for my users, this should probably happen in coordination with your fedora-release change.

My suggestion:
I will push a build of syncthing without the preset file, shortly after the fedora-release build with your changes lands in the rawhide buildroot, but before the next compose.

Sound good?

Comment 6 Zbigniew Jędrzejewski-Szmek 2019-05-09 15:28:43 UTC
Yep, I should have done this in a different order. I wasn't expecting such a quick reply ;)

https://src.fedoraproject.org/rpms/fedora-release/pull-request/80. I'll ping you here when it is pushed.

Comment 7 Fabio Valentini 2019-05-09 15:45:16 UTC
Thanks, great! I'll prepare the syncthing update in the meantime.

Comment 8 Ben Cotton 2019-08-13 17:11:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 9 Ben Cotton 2019-08-13 19:21:13 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 10 Zbigniew Jędrzejewski-Szmek 2020-03-03 07:49:31 UTC
Please drop the separate preset file now in rawhide/F32.

Comment 11 Fabio Valentini 2020-03-03 08:44:28 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1473221

Comment 12 Fabio Valentini 2020-03-03 08:47:46 UTC
Submitted for f32:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-4e0a6aeef4

But bodhi is broken and didn't update this bug.

Comment 13 Zbigniew Jędrzejewski-Szmek 2020-03-03 09:00:05 UTC
> But bodhi is broken and didn't update this bug.

We're in beta freeze, so it'll need to wait. I think bodhi is correct here.

Comment 14 Fedora Update System 2020-03-03 16:10:19 UTC
syncthing-1.3.4-2.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4e0a6aeef4

Comment 15 Fedora Update System 2020-03-16 20:20:17 UTC
syncthing-1.3.4-2.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2020-03-16 20:31:55 UTC
syncthing-1.3.4-2.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.