Bug 1709078

Summary:	automake ships binary with wrong shebangs
Product:	[Fedora] Fedora	Reporter:	Philippe Troin <phil>
Component:	automake	Assignee:	Jakub Jančo <jjanco>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	30	CC:	cquike, jjanco, karsten, kasal, panovotn, praiskup
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	automake-1.16.1-10.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-17 01:04:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Philippe Troin 2019-05-13 01:56:08 UTC

Description of problem:
The binaries shipping with automake in /usr/share/automake-1.16 that will be copied with `autoreconf' have a shebang altered to #!/usr/bin/sh.
Since these binaries will run on other systems than Fedora, they should keep their unchanged #!/bin/sh shebang.
The rpmbuild shebang auto-correction interferes and should be disabled for these scripts installed in /usr/share/automake-1.16.

Version-Release number of selected component (if applicable):
automake-1.16.1-9.fc30.noarch

How reproducible:
Always.

Comment 1 Jakub Jančo 2019-05-13 05:37:23 UTC

Hello, do you mean you use automake to build binaries for another system, that are altered, or automake's binaries have #!/usr/bin/sh? In first case I recommend building on same system. In second case rpm was built primarily for Fedora.

Comment 2 Pavel Raiskup 2019-05-13 06:57:42 UTC

With autotools, you often expect that tooling installed on Fedora is
re-distributed by `make dist` "release" tarballs.  So yes,
/usr/share/automake-1.16 scripts should have the original cross-distro
compatbile shebang (which is /bin/sh, not /usr/bin/sh).

Comment 3 Pavel Raiskup 2019-05-13 11:51:04 UTC

Please cite the change url:
https://src.fedoraproject.org/rpms/automake/c/ce2868dd7eb746a49109fb899806b1e08f4db831?branch=master

LGTM, except that I'm not sure what you mean by "bootstraped" project.

Comment 4 Fedora Update System 2019-05-13 12:52:27 UTC

automake-1.16.1-10.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-71e5a3b065

Comment 5 Fedora Update System 2019-05-14 01:53:42 UTC

automake-1.16.1-10.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-71e5a3b065

Comment 6 Fedora Update System 2019-05-17 01:04:44 UTC

automake-1.16.1-10.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Enrique 2019-11-27 18:43:23 UTC

Hi,

this is also affecting Fedora 29. Could it be possible to recreate the RPM for Fedora 29 as well?

Thank you