Bug 170959

Summary: smartmontools spec file cleanup
Product: [Fedora] Fedora Reporter: Robert Scheck <redhat-bugzilla>
Component: smartmontoolsAssignee: Tomas Mraz <tmraz>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: smartmontools-5.33-2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-11-03 18:53:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Diff/patch of smartmontools spec files
none
Diff/patch of smartmontools spec files none

Description Robert Scheck 2005-10-16 11:22:14 UTC 
Description of problem:
It is not really problem, but the spec file of smartmontools should be cleaned 
up a bit. RPM has enough macros for simplifing some things.

Oh and I'm not sure, but is it possible, that "smartd-conf.py" is broken (by the 
new kudzu)? Would be very nice, if somebody of Red Hat could verify this to be 
sure...

Version-Release number of selected component (if applicable):
smartmontools-5.33-1.7

Actual results/Expected results:
See attached patch.
Comment 1 Robert Scheck 2005-10-16 11:24:08 UTC 
Created attachment 120033 [details]
Diff/patch of smartmontools spec files
Comment 2 Dave Jones 2005-10-25 09:02:30 UTC 
(05:02:29:davej@devserv:devel)$ cat attachment.cgi\?id\=120033 | patch -p0
patching file smartmontools.spec
Hunk #1 FAILED at 5.
Hunk #2 FAILED at 69.
2 out of 2 hunks FAILED -- saving rejects to file smartmontools.spec.rej


Corrupted diff  ?? Changes look sane though.
Comment 3 Robert Scheck 2005-10-25 17:22:44 UTC 
Created attachment 120375 [details]
Diff/patch of smartmontools spec files

Dave, this seems to be my fault, sorry. I merged my changes and re-diffed
against CVS - attached to this bug report, if you want it.
Comment 4 Tomas Mraz 2005-11-03 18:53:27 UTC 
Applied, thank you.