Bug 1710021
| Summary: | openstack tripleo container image prepare default generates settings twice | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Ronelle Landy <rlandy> |
| Component: | openstack-tripleo-common | Assignee: | Martin André <m.andre> |
| Status: | CLOSED NOTABUG | QA Contact: | Alexander Chuzhoy <sasha> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 14.0 (Rocky) | CC: | aschultz, m.andre, mburns, slinaber, whayutin |
| Target Milestone: | --- | Keywords: | PromotionBlocker, ZStream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-05-17 11:13:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Martin, the bug has nothing to do w/ the job passing or failing. The bug is only about the parameters getting generated twice. In manual runs, we have modified the output-env-file to remove the 'includes' section and the stack creation completed. Kicking off a run with the exact revert to check. Martin, help me understand... It doesn't make sense why the file would have both --include and --excludes openshift. Why would this be the case? Also why is there difference between rocky and osp-14 in this regard? (In reply to wes hayutin from comment #6) > Martin, help me understand... > It doesn't make sense why the file would have both --include and --excludes > openshift. Why would this be the case? > Also why is there difference between rocky and osp-14 in this regard? For all non OpenShift images (the struct with exludes: [openshift]), we want them to be processed the same way they used to be processed with tag_from_label, no changes for them. For all OpenShift images (the stuct with includes: [openshift]), we do not want to retag the images so we removed the tag_from_label key. However, in order to get tripleo-common to happily process the file we had to duplicate some of the openshift keys in the exclude block. That's what makes it confusing. Now, it's downstream only because it fixes a bug [1] that only manifests downstream. The bug is caused by the downstream image naming and sometime inconsistent tagging, and I didn't want to introduce the extra complexity uptream where it's not needed. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1659183 Closing as NOTABUG, we found the issue is in how tripleo-quickstart processes the containers-prepare-parameters.yaml file. |
Description of problem: openstack tripleo container image prepare default in rhos-14 generates settings twice (under -excludes opensthift and include openshift). Note that this is different in Rocky. *** In Rocky **** # Generated with the following on 2019-05-13T19:30:15.740855 # # openstack tripleo container image prepare default --output-env-file /home/zuul/containers-prepare-parameters.yaml # parameter_defaults: ContainerImagePrepare: - set: ceph_image: daemon ceph_namespace: docker.io/ceph ceph_tag: v3.2.1-stable-3.2-luminous-centos-7-x86_64 name_prefix: centos-binary-openstack tripleo container image prepare default name_suffix: '' namespace: docker.io/tripleorocky neutron_driver: null openshift_asb_namespace: docker.io/ansibleplaybookbundle openshift_asb_tag: latest openshift_cluster_monitoring_image: coreos-cluster-monitoring-operator openshift_cluster_monitoring_namespace: docker.io/tripleorocky openshift_cluster_monitoring_tag: v0.1.1 openshift_cockpit_image: kubernetes openshift_cockpit_namespace: docker.io/cockpit openshift_cockpit_tag: latest openshift_configmap_reload_image: coreos-configmap-reload openshift_configmap_reload_namespace: docker.io/tripleorocky openshift_configmap_reload_tag: v0.0.1 openshift_etcd_image: etcd openshift_etcd_namespace: registry.fedoraproject.org/latest openshift_etcd_tag: latest openshift_gluster_block_image: glusterblock-provisioner openshift_gluster_image: gluster-centos openshift_gluster_namespace: docker.io/gluster openshift_gluster_tag: latest openshift_grafana_namespace: docker.io/grafana openshift_grafana_tag: 5.2.1 openshift_heketi_image: heketi openshift_heketi_namespace: docker.io/heketi openshift_heketi_tag: latest openshift_kube_rbac_proxy_image: coreos-kube-rbac-proxy openshift_kube_rbac_proxy_namespace: docker.io/tripleorocky openshift_kube_rbac_proxy_tag: v0.3.1 openshift_kube_state_metrics_image: coreos-kube-state-metrics openshift_kube_state_metrics_namespace: docker.io/tripleorocky openshift_kube_state_metrics_tag: v1.3.1 openshift_namespace: docker.io/openshift openshift_oauth_proxy_tag: v1.1.0 openshift_prefix: origin openshift_prometheus_alertmanager_tag: v0.15.2 openshift_prometheus_config_reload_image: coreos-prometheus-config-reloader openshift_prometheus_config_reload_namespace: docker.io/tripleorocky openshift_prometheus_config_reload_tag: v0.23.2 openshift_prometheus_node_exporter_tag: v0.16.0 openshift_prometheus_operator_image: coreos-prometheus-operator openshift_prometheus_operator_namespace: docker.io/tripleorocky openshift_prometheus_operator_tag: v0.23.2 openshift_prometheus_tag: v2.3.2 openshift_tag: v3.11.0 tag: current-tripleo tag_from_label: rdo_version **** In rhos-14: **** # Generated with the following on 2019-05-14T14:15:26.514252 # # openstack tripleo container image prepare default --output-env-file /home/zuul/omg01.yaml # parameter_defaults: ContainerImagePrepare: - excludes: - openshift set: ceph_image: rhceph-3-rhel7 ceph_namespace: registry.access.redhat.com/rhceph ceph_tag: latest name_prefix: openstack- name_suffix: '' namespace: registry.access.redhat.com/rhosp14 neutron_driver: null openshift_asb_namespace: registry.access.redhat.com/openshift3 openshift_cluster_monitoring_namespace: registry.access.redhat.com/openshift3 openshift_cockpit_namespace: registry.access.redhat.com/openshift3 openshift_configmap_reload_namespace: registry.access.redhat.com/openshift3 openshift_etcd_image: etcd openshift_etcd_namespace: registry.access.redhat.com/rhel7 openshift_etcd_tag: latest openshift_gluster_block_image: rhgs-gluster-block-prov-rhel7 openshift_gluster_image: rhgs-server-rhel7 openshift_gluster_namespace: registry.access.redhat.com/rhgs3 openshift_gluster_tag: v3.11 openshift_grafana_namespace: registry.access.redhat.com/openshift3 openshift_heketi_image: rhgs-volmanager-rhel7 openshift_heketi_namespace: registry.access.redhat.com/rhgs3 openshift_heketi_tag: v3.11 openshift_kube_rbac_proxy_namespace: registry.access.redhat.com/openshift3 openshift_kube_state_metrics_namespace: registry.access.redhat.com/openshift3 openshift_namespace: registry.access.redhat.com/openshift3 openshift_prometheus_config_reload_namespace: registry.access.redhat.com/openshift3 openshift_prometheus_operator_namespace: registry.access.redhat.com/openshift3 tag: latest tag_from_label: '{version}-{release}' - includes: - openshift set: openshift_asb_namespace: registry.access.redhat.com/openshift3 openshift_asb_tag: v3.11 openshift_cluster_monitoring_image: ose-cluster-monitoring-operator openshift_cluster_monitoring_namespace: registry.access.redhat.com/openshift3 openshift_cluster_monitoring_tag: v3.11 openshift_cockpit_image: registry-console openshift_cockpit_namespace: registry.access.redhat.com/openshift3 openshift_cockpit_tag: v3.11 openshift_configmap_reload_image: ose-configmap-reloader openshift_configmap_reload_namespace: registry.access.redhat.com/openshift3 openshift_configmap_reload_tag: v3.11 openshift_grafana_namespace: registry.access.redhat.com/openshift3 openshift_grafana_tag: v3.11 openshift_kube_rbac_proxy_image: ose-kube-rbac-proxy openshift_kube_rbac_proxy_namespace: registry.access.redhat.com/openshift3 openshift_kube_rbac_proxy_tag: v3.11 openshift_kube_state_metrics_image: ose-kube-state-metrics openshift_kube_state_metrics_namespace: registry.access.redhat.com/openshift3 openshift_kube_state_metrics_tag: v3.11 openshift_namespace: registry.access.redhat.com/openshift3 openshift_oauth_proxy_tag: v3.11 openshift_prefix: ose openshift_prometheus_alertmanager_tag: v3.11 openshift_prometheus_config_reload_image: ose-prometheus-config-reloader openshift_prometheus_config_reload_namespace: registry.access.redhat.com/openshift3 openshift_prometheus_config_reload_tag: v3.11 openshift_prometheus_node_exporter_tag: v3.11 openshift_prometheus_operator_image: ose-prometheus-operator openshift_prometheus_operator_namespace: registry.access.redhat.com/openshift3 openshift_prometheus_operator_tag: v3.11 openshift_prometheus_tag: v3.11 openshift_tag: v3.11 This causes errors in the standalone deployment: https://sf.hosted.upshift.rdu2.redhat.com/logs/periodic/code.engineering.redhat.com/openstack/tripleo-ci-internal-jobs/master/tripleo-ci-rhel-7-standalone-rhos-14/02d6eff/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz Version-Release number of selected component (if applicable): puddle_baseurl=http://download.devel.redhat.com/rcm-guest/puddles/OpenStack/14.0-RHEL-7/2019-04-29.1/RH7-RHOS-14.0/ Installed on rhel 7.6 This has been failing since late-April. How reproducible: Fails consistently in CI Steps to Reproduce: 1. In rhos-14 passed_phase_2 2. openstack tripleo container image prepare default --output-env-file /home/zuul/test.yaml 3. See settings difference. Actual results: duplicated settings Expected results: Same results as rocky. Additional info: