Bug 1710532

Summary: [bat] nfs.conf rdma setting not implemented
Product: Red Hat Enterprise Linux 8 Reporter: Benjamin Coddington <bcodding>
Component: nfs-utilsAssignee: Steve Dickson <steved>
Status: CLOSED ERRATA QA Contact: Yongcheng Yang <yoyang>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 8.1CC: ajmitchell, jiyin, nfs-maint, steved, swhiteho, xzhou
Target Milestone: rcKeywords: Patch
Target Release: 8.0Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nfs-utils-2.3.3-27.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 16:51:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Benjamin Coddington 2019-05-15 17:21:47 UTC
/etc/nfs.conf:

[nfsd]
 rdma=y

Has no effect, the result is that there's no persistent way to enable RDMA service for NFS.  It looks like /etc/nfs.conf is a template, and we've removed /etc/sysconfig/nfs functionality.  All the commented out settings need to be tested.  This one, at least was never implemented.

It would make sense to not add commented-out defaults that don't have an un-commented implementation.

Comment 1 Yongcheng Yang 2019-05-16 01:56:22 UTC
Reading from the "nfsd" man page, we are using "rdma=nfsrdma" to config rdma.
------------------------------------------------------------------
# rpm -q nfs-utils
nfs-utils-2.3.3-14.el8_0.x86_64
# man nfsd | grep "Set RDMA port"
       rdma   Set RDMA port.  Use "rdma=nfsrdma" to enable standard port.
------------------------------------------------------------------

We already have testcase to cover this config, maybe need to improve checking more values.

https://beaker.engineering.redhat.com/recipes/6860717#task92692165
------------------------------------------------------------------
# {Info} Apply configuration settings to /etc/nfs.conf
[06:57:06 root@ ~~]# cat /etc/nfs.conf
[nfsd]
rdma=nfsrdma
[06:57:06 root@ ~~]# rpc.nfsd
[06:57:06 root@ ~~]# cat /proc/fs/nfsd/portlist | grep -w rdma
rdma 20049
rdma 20049
[06:57:06 root@ ~~]# rpc.nfsd 0
[06:57:06 root@ ~~]# >/etc/nfs.conf
------------------------------------------------------------------

In nfs.conf, the "rdma=n" does make users confusing.

Comment 4 Steve Dickson 2019-09-17 11:55:07 UTC
Upstream commit...

commit 0240df0e8ccf7be2706a6a10a2a620f8eda55275
Author: Yongcheng Yang <yongcheng.yang>
Date:   Thu Sep 5 07:36:26 2019 -0400

    nfsd: Adjust nfs.conf setting/parsing of rdma port

Comment 6 Yongcheng Yang 2019-12-02 08:09:25 UTC
Verified in nfs-utils-2.3.3-27.el8
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
https://beaker.engineering.redhat.com/recipes/7637495#task103017310
--------------------------------------------------------------------
# check "rdma=BOOLEAN"
[06:40:31 root@ ~~]# cat /etc/nfs.conf
[nfsd]
rdma=yes
[06:40:31 root@ ~~]# rpc.nfsd
[06:40:31 root@ ~~]# cat /proc/fs/nfsd/portlist | grep -w rdma
rdma 20049
rdma 20049
[06:40:31 root@ ~~]# rpc.nfsd 0
[06:40:31 root@ ~~]# systemctl reset-failed
[06:40:31 root@ ~~]# service_nfs restart
Redirecting to /bin/systemctl restart nfs-server.service
[06:40:31 root@ ~~]# cat /proc/fs/nfsd/portlist | grep -w rdma
rdma 20049
rdma 20049

# check "rdma-port="
[06:40:56 root@ ~~]# cat /etc/nfs.conf
[nfsd]
rdma=1   <<< Any of true, t, yes, y, on, or 1 can be used for "true"
rdma-port=45678
[06:40:56 root@ ~~]# rpc.nfsd
[06:40:56 root@ ~~]# cat /proc/fs/nfsd/portlist | grep -w rdma
rdma 45678
rdma 45678
[06:40:56 root@ ~~]# rpc.nfsd 0
[06:40:56 root@ ~~]# systemctl reset-failed
[06:40:56 root@ ~~]# service_nfs restart
Redirecting to /bin/systemctl restart nfs-server.service
[06:40:56 root@ ~~]# cat /proc/fs/nfsd/portlist | grep -w rdma
rdma 45678
rdma 45678

Comment 8 errata-xmlrpc 2020-04-28 16:51:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1832