Bug 1710888

Summary:	[UI][v2v] Create VM dialog, Pressing 'Esc' at any stage will close the dialog
Product:	OpenShift Container Platform	Reporter:	Ilanit Stein <istein>
Component:	Console Kubevirt Plugin	Assignee:	Rastislav Wagner <rawagner>
Status:	CLOSED ERRATA	QA Contact:	Guohua Ouyang <gouyang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	aos-bugs, cnv-qe-bugs, fkrepins, mlibra, ncredi, rawagner, rhrazdil, sgordon
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	2.0.0-14.6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-24 20:16:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ilanit Stein 2019-05-16 13:51:04 UTC

Description of problem:
In Create Vm wizard dialog, pressing 'Esc' at any stage will close the dialog.
The dialog should be closed by clicking 'Cancel', or clicking 'x', but not by 'Esc'.

For example, pick provision source: Import, then move to next screen - Network,
fill something,and press 'Esc' - The dialog is closed. 

Version-Release number of selected component (if applicable):
hco_tag: v.2.0.0-12

How reproducible:
100%

Comment 1 Rastislav Wagner 2019-05-20 11:55:35 UTC

https://github.com/kubevirt/web-ui-components/pull/471

Comment 2 Filip Krepinsky 2019-05-20 12:04:08 UTC

IMO this is quite normal behavior to close the dialog with escape key. Users should be accustomed to this kind of behavior.

Comment 3 Marek Libra 2019-05-20 12:17:15 UTC

It's a matter of personal preference. I consider recent behaviour of esc and clicking outside the dialog annoying and so agree with this original BZ description.

Comment 5 Rastislav Wagner 2019-05-24 10:43:50 UTC

We altered wizard behavior a bit - escape key still closes the the wizard (thats how all other modals behave in openshift ui) but wizard wont close when you click outside of modal now.

Comment 6 Marek Libra 2019-06-03 10:00:47 UTC

Included in kubevirt-2.0.0-14.6 .
Will be in hco-bundle-registry:v2.0.0-22 .

Comment 7 Radim Hrazdil 2019-06-04 12:08:14 UTC

Verified with kubevirt-web-ui-container-v2.0.0-14.6. Cluster Deployed with HCO v2.0.0-22.
Wizard is not closed when user clicks outside the wizard area.

Comment 9 errata-xmlrpc 2019-07-24 20:16:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1850