Bug 171090

Summary: Review Request: paps - Plain Text to PostScript(TM) converter
Product: [Fedora] Fedora Reporter: Akira TAGOH <tagoh>
Component: Package ReviewAssignee: Aurelien Bompard <gauret>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://people.redhat.com/tagoh/paps/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-10-25 10:54:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Akira TAGOH 2005-10-18 03:01:14 UTC 
Spec Name or Url: http://people.redhat.com/tagoh/paps/paps.spec
SRPM Name or Url: http://people.redhat.com/tagoh/paps/paps-0.3-1.src.rpm
Description: 

paps is a PostScript(TM) converter from plain text file using Pango.
Comment 1 Aurelien Bompard 2005-10-22 20:38:50 UTC 
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* The package should contain the text of the license (the COPYING file)
  (wiki: PackageReviewGuidelines)
* The package does not honor RPM_OPT_FLAGS. Building with:
  make %{?_smp_mflags} CC="gcc $RPM_OPT_FLAGS"
  should do it.
Comment 2 Akira TAGOH 2005-10-25 02:47:37 UTC 
Thank you for reviewing. I've put the updated spec file and srpm file at the
same place.
Comment 3 Aurelien Bompard 2005-10-25 07:47:37 UTC 
* RPM name is OK
* Source paps-0.3.tgz is the same as upstream
* Builds fine in mock
* rpmlint of paps looks OK
* File list of paps looks OK
* Works fine
APPROVED

Next time please increase release when updating the package, it make it easier
to know which release has been approved.
Comment 4 Akira TAGOH 2005-10-25 10:54:51 UTC 
Sure. thanks.
Comment 5 Dov Grobgeld 2005-11-03 21:03:52 UTC 
Please use paps-0.5.tgz that I just released instead. It's postscript is up to
100 times more compact and it fixes several critical layout bugs.