Bug 1710931

Summary: linux-firmware fails to build with newer firmware files from upstream
Product: Red Hat Enterprise Linux 8 Reporter: Herton R. Krzesinski <hkrzesin>
Component: linux-firmwareAssignee: Herton R. Krzesinski <hkrzesin>
Status: CLOSED ERRATA QA Contact: Rachel Sibley <rasibley>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 8.1CC: dhoward, rvr, vishal
Target Milestone: rc   
Target Release: 8.0   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: linux-firmware-20190516-94.git711d3297.el8.src.rpm Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-05 22:04:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1663989, 1664678, 1673890, 1678095, 1717787, 1726396    

Description Herton R. Krzesinski 2019-05-16 15:20:24 UTC
Description of problem:
Current checkout (799342b6c8a66f619d2277a8797b90711416d98c) of linux-firmware in rhel-8.1.0 dist-git branch fails to build with the following error:

+ /usr/lib/rpm/redhat/brp-mangle-shebangs
Processing files: linux-firmware-20190516-94.git711d3297.el8.noarch
error: File must begin with "/": PLUS.txt
Executing(%license): /bin/sh -e /var/tmp/rpm-tmp.YhAd1k
+ umask 022
+ cd /builddir/build/BUILD
+ cd linux-firmware-711d3297
+ LICENSEDIR=/builddir/build/BUILDROOT/linux-firmware-20190516-94.git711d3297.el8.noarch/usr/share/licenses/linux-firmware
+ export LC_ALL=C
+ LC_ALL=C
+ export LICENSEDIR
+ /usr/bin/mkdir -p /builddir/build/BUILDROOT/linux-firmware-20190516-94.git711d3297.el8.noarch/usr/share/licenses/linux-firmware
+ cp -pr WHENCE /builddir/build/BUILDROOT/linux-firmware-20190516-94.git711d3297.el8.noarch/usr/share/licenses/linux-firmware
+ cp -pr LICENCE.Abilis LICENCE.IntcSST2 LICENCE.Marvell LICENCE.Netronome LICENCE.OLPC LICENCE.adsp_sst LICENCE.agere LICENCE.atheros_firmware LICENCE.broadcom_bcm43xx LICENCE.ca0132 LICENCE.cadence LICENCE.cavium LICENCE.cavium_liquidio LICENCE.chelsio_firmware LICENCE.cw1200 LICENCE.cypress LICENCE.e100 LICENCE.ene_firmware LICENCE.fw_sst_0f28 LICENCE.go7007 LICENCE.i2400m LICENCE.ibt_firmware LICENCE.it913x LICENCE.iwlwifi_firmware LICENCE.kaweth LICENCE.mediatek LICENCE.microchip LICENCE.moxa LICENCE.myri10ge_firmware LICENCE.nvidia LICENCE.open-ath9k-htc-firmware LICENCE.phanfw LICENCE.qat_firmware LICENCE.qla1280 LICENCE.qla2xxx LICENCE.r8a779x_usb3 LICENCE.ralink-firmware.txt LICENCE.ralink_a_mediatek_company_firmware LICENCE.rockchip LICENCE.rtlwifi_firmware.txt LICENCE.siano LICENCE.tda7706-firmware.txt LICENCE.ti-connectivity LICENCE.ti-keystone LICENCE.ueagle-atm4-firmware LICENCE.via_vt6656 LICENCE.wl1251 LICENCE.xc4000 LICENCE.xc5000 LICENCE.xc5000c /builddir/build/BUILDROOT/linux-firmware-20190516-94.git711d3297.el8.noarch/usr/share/licenses/linux-firmware
+ cp -pr LICENSE.QualcommAtheros_ar3k LICENSE.QualcommAtheros_ath10k LICENSE.amd-sev LICENSE.amd-ucode LICENSE.amdgpu LICENSE.amlogic_vdec LICENSE.atmel LICENSE.dib0700 LICENSE.hfi1_firmware LICENSE.i915 LICENSE.ipu3_firmware LICENSE.nxp_mc_firmware LICENSE.qcom LICENSE.radeon LICENSE.sdma_firmware /builddir/build/BUILDROOT/linux-firmware-20190516-94.git711d3297.el8.noarch/usr/share/licenses/linux-firmware
+ exit 0
RPM build errors:
    Macro expanded in comment on line 17: %{checkout}/ %{checkout} | xz > linux-firmware-%{version}.tar.xz
    File must begin with "/": PLUS.txt
Child return code was: 1
EXCEPTION: [Error()]

(Full log: http://download.eng.bos.redhat.com/brewroot/work/tasks/5644/21725644/build.log)

Version-Release number of selected component (if applicable):
linux-firmware-20190516-94.git711d3297.el8

Additional info:

Fedora seems to have this already fixed in the following commit:

commit 662f6f2711c8f2e87ba6cbe4c0f88d78fbaf5f7d
Author: Josh Boyer <jwboyer>
Date:   Thu Dec 20 07:46:16 2018 -0500
    
    Add double quotes around file names
    
    Upstream added board nvram files that use spaces in their names.
    We need to quote the filenames so RPM doesn't puke on the filelist

Comment 5 errata-xmlrpc 2019-11-05 22:04:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3526