Bug 1710998

Summary: Assigned filters don't work if datastore is deleted which has the filter assigned and it shows every cluster regardless of the assignment
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: ApplianceAssignee: Libor Pichler <lpichler>
Status: CLOSED ERRATA QA Contact: Devidas Gaikwad <dgaikwad>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.9.6CC: abellott, anikifor, apagac, bmidwood, dgaikwad, dmetzger, dsundqvi, gtanzill, hkataria, jprause, lavenel, lpichler, mpovolny, mshriver, obarenbo, simaishi
Target Milestone: GAKeywords: ZStream
Target Release: 5.10.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1693183 Environment:
Last Closed: 2019-06-11 05:32:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1693183    
Bug Blocks:    

Comment 2 CFME Bot 2019-05-20 18:05:52 UTC 
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/29f4d73b74fd7a0f742309a6c69002141b24b4b9
commit 29f4d73b74fd7a0f742309a6c69002141b24b4b9
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Fri May  3 16:55:37 2019 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Fri May  3 16:55:37 2019 -0400

    Merge pull request #18651 from lpichler/skip_belongsto_filter_when_any_object_doenst_exists

    Doesn't count with selection of belongsto filter if any object doesn't exist in the filter sentence

    (cherry picked from commit fdc1b6d6245f68c7c4d55ee4b140089622df73ac)

    https://bugzilla.redhat.com/show_bug.cgi?id=1710998

 app/models/miq_filter.rb | 6 +-
 spec/lib/rbac/filterer_spec.rb | 38 +-
 2 files changed, 37 insertions(+), 7 deletions(-)
Comment 3 CFME Bot 2019-05-20 18:16:42 UTC 
New commits detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/04506ead4309c917c3db96c1b157b9b46c4e7cd8
commit 04506ead4309c917c3db96c1b157b9b46c4e7cd8
Author:     Martin Hradil <mhradil>
AuthorDate: Thu May  9 10:19:56 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Thu May  9 10:19:56 2019 -0400

    Merge pull request #5511 from lpichler/inform_user_about_outdates_belongsto_filters

    Inform user about outdates belongsto filters

    (cherry picked from commit 23ee13fe4aa7a2e284e6156839857a2eb325d76e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1710998

 app/controllers/ops_controller/ops_rbac.rb | 21 +-
 app/views/ops/_rbac_group_details.html.haml | 14 +
 spec/controllers/ops_controller/ops_rbac_spec.rb | 100 +
 3 files changed, 130 insertions(+), 5 deletions(-)
Comment 4 Antonin Pagac 2019-05-31 10:59:37 UTC 
Appliance version 5.10.5.0.

Removing an item now does not cause displaying unwanted items. There's warning displayed when looking at a group with outdated filters:

"These outdated filters need review as it affects their visibility. We suggest editing and saving the group to delete these outdated filters."
Comment 6 errata-xmlrpc 2019-06-11 05:32:44 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:1429
Comment 8 Devidas Gaikwad 2020-07-02 17:45:47 UTC 
Hello Libor,
Could you please add test steps to automate this BZ?