Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1711135

Summary:	Wrong PR link in changelog https://openshift-release.svc.ci.openshift.org
Product:	OpenShift Container Platform	Reporter:	Liang Xia <lxia>
Component:	Release	Assignee:	Luke Meyer <lmeyer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Wei Sun <wsun>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.1.0	CC:	aos-bugs, ccoleman, jforrest, jokerman, lmeyer, mmccomas, vlaad, wking
Target Milestone:	---
Target Release:	4.3.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-29 15:43:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Comment 1 Clayton Coleman 2019-05-17 04:53:03 UTC

If we expect issues and PRs to come from origin we can force them to point to the right location.  However, it would be better to have the URL in the PR merge commit.

Comment 2 Luke Meyer 2019-05-17 14:04:20 UTC

This just affects changelogs, so no functional issue.

Sounds like the logic is just taking the commit number from a merge commit like https://github.com/openshift/origin/commit/feaf8a97d317a15887863c3f25fecb2e23a81311 (Merge pull request #22849 ...) and slapping it on the source repo (in this case, origin is synced to ose and that's where we build from). That should be the only source of the problem at this point we can expect other repos to come from private forks occasionally in the future too.

For this reason, it would be best if openshift-merge-bot included the full URL in the merge commit msg in a way that the logic can use that directly when it flows into a different repo.

As a short term fix, consider having a special case in the release controller for rewriting ose -> origin URLs (since PRs will virtually always come from origin).

Comment 3 Luke Meyer 2019-05-17 14:12:17 UTC

in ^^
"commit number" -> "PR number"
"full URL in the merge commit msg" -> "full URL to the PR in the merge commit msg"

Comment 8 Luke Meyer 2020-05-29 15:43:21 UTC

This was fixed by recent changes (can't recall how recent).

e.g.

https://openshift-release.svc.ci.openshift.org/releasestream/4-stable/release/4.3.22 shows hyperkube with origin PRs

$ oc image info $(oc adm release info  --image-for hyperkube quay.io/openshift-release-dev/ocp-release:4.3.22-x86_64) | grep commit.url
             io.openshift.build.commit.url=https://github.com/openshift/origin/commit/fc799343c22c999ec561b3e47073e7b4c2812d69