Bug 1711374

Summary: runtime crashes when built with -D_GLIBC_ASSERTIONS
Product: [Fedora] Fedora Reporter: Frederic Han <frederic.han>
Component: giacAssignee: Antonio T. (sagitter) <anto.trande>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: anto.trande, frederic.han
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: giac-1.5.0.53-1.fc30 giac-1.5.0.53-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-27 01:02:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix for giac <1.5.0.53
none
Fixes changes in the testsuite due to pari 2.11 and later. none

Description Frederic Han 2019-05-17 15:59:09 UTC
Created attachment 1570167 [details]
Fix for giac <1.5.0.53

Description of problem:
The giac packages built with -D_GLIBC_ASSERTIONS gives crashes at run time. But this flag looks defined by default since fc28. 

Version-Release number of selected component (if applicable):
all giac versions <1.5.0.53  on fc28 and later

How reproducible:
anytime  on  x86_64, not tested on other arch.

Steps to Reproduce:
1. launch the program icas and try
2. ifactor(10**40+68)

Actual results:
0>> ifactor(10**40+68)
/usr/include/c++/8/bits/stl_vector.h:932: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = giac::basis_t; _Alloc = std::allocator<giac::basis_t>; std::vector<_Tp, _Alloc>::reference = giac::basis_t&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.
Aborted (core dumped)


Expected results:
0>> ifactor(10**40+68)
2^2*3*19391*3575030373429491*12020950579264347719

Additional info:
This is fixed in upstream source 1.5.0-53
or with the following patch.

Comment 1 Frederic Han 2019-05-17 16:07:18 UTC
Created attachment 1570168 [details]
Fixes changes in the testsuite due to pari 2.11 and later.

The patch giac-testsuite_pari_2.11.patch 
allowed me to run the test suite without errors (on x86_64). (Some outputs are different when giac is built with pari versions >2.11

Comment 2 Fedora Update System 2019-05-18 14:24:24 UTC
giac-1.5.0.53-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-dee9e49f52

Comment 3 Fedora Update System 2019-05-18 14:24:28 UTC
giac-1.5.0.53-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e7d4d11851

Comment 4 Fedora Update System 2019-05-19 00:51:35 UTC
giac-1.5.0.53-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-dee9e49f52

Comment 5 Fedora Update System 2019-05-19 10:49:53 UTC
giac-1.5.0.53-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e7d4d11851

Comment 6 Fedora Update System 2019-05-27 01:02:17 UTC
giac-1.5.0.53-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2019-05-29 02:59:21 UTC
giac-1.5.0.53-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.