Bug 1712872

Summary: vms/instances view gets broken after attempt to open advanced search
Product: Red Hat CloudForms Management Engine Reporter: Ievgen Zapolskyi <izapolsk>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED CURRENTRELEASE QA Contact: Ievgen Zapolskyi <izapolsk>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.5CC: bmidwood, hkataria, lavenel, mpovolny, obarenbo, rspagnol, simaishi
Target Milestone: GAKeywords: Regression, TestOnly, ZStream
Target Release: 5.11.0Flags: izapolsk: automate_bug+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1717923 (view as bug list) Environment:
Last Closed: 2019-12-13 15:09:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1717923    
Attachments:
Description Flags
screenshot none

Description Ievgen Zapolskyi 2019-05-22 11:39:49 UTC
Created attachment 1571971 [details]
screenshot

Description of problem:
It seems advanced search isn't initialized correctly when vms/instances page is open via providers/clusters/etc page. vms/instances gets faded loosing all controls after clicking advanced search 

Version-Release number of selected component (if applicable):
5.10.5.0

How reproducible:
100%

Steps to Reproduce:
1. Add f.e. infra provider vsphere67-nested and wait until its info about vms is collected
2. Open Compute->Infrastructure->Providers
3. Click Provider
4. Click Vms on Dashboard/Summary page
5. Click any vm
6. Choose History->All Vms & Templates
7. Click VMs accordion
8. Click Advanced Search button several times

Actual results:
Advanced Search doesn't appear or VMs page gets faded

Expected results:
correct behavior of Advanced Search dialog

Additional info: look at screenshot

Comment 9 CFME Bot 2019-06-05 19:23:57 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/37f7d5fbb7618cd6f50ab71a0cd7c3113f928896
commit 37f7d5fbb7618cd6f50ab71a0cd7c3113f928896
Author:     Martin Hradil <mhradil>
AuthorDate: Mon May 27 08:54:56 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Mon May 27 08:54:56 2019 -0400

    adv_search - move show_adv_search? logic inside adv_search_{body,footer} divs

    we replace those divs' content when doing ajax transitions, so they have to be present unconditionally
    they don't have to have anything inside though

    Also, a bunch of url_for calls need to only happen under that condition, so moved too.
    (Not all controllers have a `adv_search_load_choice` route for example.)

    (also fixes random missing gettext around Close)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1712872

 app/views/layouts/_adv_search.html.haml | 54 +-
 app/views/layouts/_adv_search_body.html.haml | 157 +-
 app/views/layouts/_adv_search_footer.html.haml | 178 +-
 3 files changed, 197 insertions(+), 192 deletions(-)

Comment 11 Ievgen Zapolskyi 2019-06-14 08:54:54 UTC
Verified in 5.11.0.8