Bug 1713010

Summary:	AWS provider removes stopped instances when reconciling machines
Product:	OpenShift Container Platform	Reporter:	Michael Gugino <mgugino>
Component:	Cloud Compute	Assignee:	Michael Gugino <mgugino>
Status:	CLOSED ERRATA	QA Contact:	Jianwei Hou <jhou>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	agarcial, zhsun
Target Milestone:	---
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1718265 (view as bug list)		Environment:
Last Closed:	2019-10-16 06:29:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1718265

Description Michael Gugino 2019-05-22 16:55:04 UTC

Description of problem:

If a cloud instance backing a machine has stopped, and the machine is reconciled again later for some reason, the stopped instance will be deleted and a new instance will be created in its place.  This behavior is undocumented, likely unexpected, and probably something we should remove.

Comment 1 Michael Gugino 2019-06-07 11:42:25 UTC

Merged in master.

Comment 2 Michael Gugino 2019-06-17 13:51:28 UTC

How to verify QE:

Prior to this patch:
1) Stop a worker instance in AWS console.
2) Wait for node to go unready.
3) After node is unready, in a minute or two you should see a new instance provisioned in AWS console with same tag.Name as instance you stopped.
4) Old instance will be terminated.

1) Stop a worker instance in AWS console.
2) Wait for node to go unready.
3) After node is unready, after a few minutes, verify there are no new instances with same tag.Name in AWS console as the instnace you stopped.
4) Instance will not be terminated and can be successfully restarted.

Comment 3 sunzhaohua 2019-06-18 09:10:28 UTC

Verified.

clusterversion: 4.2.0-0.ci-2019-06-18-001241

Stop a worker instance, there are no new instance with same tag.Name was provisioned. If start the instance in AWS console the node could join the cluster.

Comment 5 errata-xmlrpc 2019-10-16 06:29:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922