Bug 1713072

Summary: Scheduled Automation Task Fails After 1st Run
Product: Red Hat CloudForms Management Engine Reporter: Tuan <tuado>
Component: AutomateAssignee: drew uhlmann <duhlmann>
Status: CLOSED CURRENTRELEASE QA Contact: Ganesh Hubale <ghubale>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.9.9CC: dmetzger, duhlmann, gmccullo, jocarter, jprause, mkanoor, mshriver, ngupta, obarenbo, simaishi, tfitzger
Target Milestone: GAKeywords: Reopened, TestOnly, ZStream
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.22 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1745197 (view as bug list) Environment:
Last Closed: 2019-12-13 14:57:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1745197    

Comment 2 drew uhlmann 2019-05-23 13:07:21 UTC
Hey Tuan, any chance you could give me a reproducer for this, please?

Comment 14 drew uhlmann 2019-08-20 11:51:05 UTC
You're talking about the fact that it doesn't show up in the UI, right? It's logging the message and system/process fine, but not showing up in the UI after the first run is completed. Is that correct? 

This bug was opened because it was originally failing after the first run, I'm not seeing it fail anymore.

Comment 15 Tina Fitzgerald 2019-08-20 15:32:24 UTC
Hi Nikhil,

I understand you encountered missing parameters while testing the code changes.

Did the code change resolve the originally reported problem of the "External management system not found - ems is blank" error?

Thanks,
Tina

Comment 16 drew uhlmann 2019-08-20 18:46:50 UTC
Target release isn't set on this so I don't think it really matters when it gets in anyway. 

It'd be super-cool to get this into five ten, anyone want to set that for me please?

Comment 17 Nikhil Gupta 2019-08-21 06:35:38 UTC
Hi Drew and Tina,

My cfme version is 5.10.6.1 and I didn't receive the "External management system not found - ems is blank" error message earlier as well. 
Yes Drew, you are correct. I will check with customer and ask for his observations.

Regards,
Nikhil

Comment 18 drew uhlmann 2019-08-21 13:56:07 UTC
Hey Nikhil, I expect after a second look that the issue you're referring to will likely be resolved by the rest of the changes made in the PR in comment 12 as it's been updated. 

Anyone on triage reading this, this still won't get into the right version even if it's merged since the ticket has no target release, again.

Comment 19 drew uhlmann 2019-08-22 12:18:14 UTC
Thanks Dennis and GM.

Comment 21 CFME Bot 2019-08-23 21:16:23 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/c4ebda3585b920ffd332d32d367382b78ac3f007
commit c4ebda3585b920ffd332d32d367382b78ac3f007
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Aug 22 08:16:53 2019 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Thu Aug 22 08:16:53 2019 -0400

    Merge pull request #19158 from d-m-u/successive_automation_task_runs_should_not_remove_params

    Successive automation task runs shouldn't change the original params

    (cherry picked from commit c86ed36af6ffa758dfaf20e213b44b065ac8fd3f)

    https://bugzilla.redhat.com/show_bug.cgi?id=1713072

 app/models/automation_request.rb | 32 +-
 spec/models/automation_request_spec.rb | 20 +-
 spec/models/miq_schedule_spec.rb | 5 +-
 3 files changed, 26 insertions(+), 31 deletions(-)

Comment 22 Ganesh Hubale 2019-08-29 09:11:03 UTC
Fixed!

Verified on version: 5.11.0.22.20190827200559_e618ece