Created attachment 1572162[details]
build.log from Koji
See https://koji.fedoraproject.org/koji/taskinfo?taskID=35001283
======================================================================
ERROR: test_changelog (tests.test_changelog.ChangelogTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/builddir/build/BUILD/compose-utils-0.1.27/tests/test_changelog.py", line 92, in test_changelog
data = changelog.get_changelog(old_compose, new_compose)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 294, in get_changelog
srpm_headers_old = self.read_srpm_headers(srpms_old)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 194, in read_srpm_headers
pool.stop()
File "/usr/lib/python3.7/site-packages/kobo/threads.py", line 120, in stop
six.reraise(exc_info[0], exc_info[1], exc_info[2])
File "/usr/lib/python3.7/site-packages/six.py", line 693, in reraise
raise value
File "/usr/lib/python3.7/site-packages/kobo/threads.py", line 67, in run
self.process(item, num)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 89, in process
rpm_obj = self.pool.file_cache.add(file_path)
File "/usr/lib/python3.7/site-packages/kobo/pkgset.py", line 257, in add
value = file_wrapper_class(file_path, stat=st, **kwargs)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 60, in __init__
super(SimpleRpmWrapperWithChangelog, self).__init__(file_path, **kwargs)
File "/usr/lib/python3.7/site-packages/kobo/pkgset.py", line 179, in __init__
self.name = kobo.rpmlib.get_header_field(header, "name").decode('utf-8')
AttributeError: 'str' object has no attribute 'decode'
======================================================================
ERROR: test_changelog_with_modular_suffix (tests.test_changelog.ChangelogTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/builddir/build/BUILD/compose-utils-0.1.27/tests/test_changelog.py", line 179, in test_changelog_with_modular_suffix
data = changelog.get_changelog(old_compose, new_compose)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 294, in get_changelog
srpm_headers_old = self.read_srpm_headers(srpms_old)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 194, in read_srpm_headers
pool.stop()
File "/usr/lib/python3.7/site-packages/kobo/threads.py", line 120, in stop
six.reraise(exc_info[0], exc_info[1], exc_info[2])
File "/usr/lib/python3.7/site-packages/six.py", line 693, in reraise
raise value
File "/usr/lib/python3.7/site-packages/kobo/threads.py", line 67, in run
self.process(item, num)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 89, in process
rpm_obj = self.pool.file_cache.add(file_path)
File "/usr/lib/python3.7/site-packages/kobo/pkgset.py", line 257, in add
value = file_wrapper_class(file_path, stat=st, **kwargs)
File "/builddir/build/BUILD/compose-utils-0.1.27/compose_utils/changelog.py", line 60, in __init__
super(SimpleRpmWrapperWithChangelog, self).__init__(file_path, **kwargs)
File "/usr/lib/python3.7/site-packages/kobo/pkgset.py", line 179, in __init__
self.name = kobo.rpmlib.get_header_field(header, "name").decode('utf-8')
AttributeError: 'str' object has no attribute 'decode'
----------------------------------------------------------------------
Ran 99 tests in 2.736s
FAILED (errors=2)
Full logs attached.
The failure looks very much like bz1693751.
This blocks the Python 3.8 rebuild but also happens with Python 3.7.
This is a problem in Kobo, and there's not much that can be done about it directly in compose-utils (other than dropping use of kobo). I'll change components accordingly.