Bug 1713239

Summary:	git-2.21.0-1.fc31 FTBFS: tests fail
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	git	Assignee:	Todd Zullinger <tmz>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	30	CC:	amahdal, besser82, c.david86, chrisw, pcahyna, pstodulk, sebastian.kisela, tmz
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://apps.fedoraproject.org/koschei/build/6206870
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-26 03:25:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1709624
Bug Blocks:

Description Petr Pisar 2019-05-23 08:33:19 UTC

git-2.21.0-1.fc31 fails to build in F31 because tests fail:

t5310-pack-bitmaps.sh ..............................
[...]
ok 35 - pack with missing parent
not ok 36 - we can read jgit bitmaps
#	
#		git clone --bare . compat-jgit.git &&
#		(
#			cd compat-jgit.git &&
#			rm -f .git/objects/pack/*.bitmap &&
#			jgit gc &&
#			git rev-list --test-bitmap HEAD
#		)
#	
not ok 37 - jgit can read our bitmaps
#	
#		git clone --bare . compat-us.git &&
#		(
#			cd compat-us.git &&
#			git repack -adb &&
#			# jgit gc will barf if it does not like our bitmaps
#			jgit gc
#		)
#	
[...]
# failed 2 among 46 test(s)
1..46
Dubious, test returned 1 (wstat 256, 0x100)
Failed 2/46 subtests 

There more tests that failed.

A difference between passing and failing build root is at <https://apps.fedoraproject.org/koschei/build/6206870>.

This also manifests in Fedora 30.

Comment 1 Petr Pisar 2019-05-23 08:36:27 UTC

This seems to be triggered by upgrading jgit from 5.2.0 to 5.3.0.

Comment 2 Todd Zullinger 2019-05-23 13:49:28 UTC

This is most likely due to jgit being completely broken, as noted in #1709624.  (FYI, the kochei links seem to lack build.log output, so I can't confirm this with certainty for those builds.)

I recently improved the git tests to check whether jgit starts in 5161099 ("Improve JGIT test prereq (jgit on Fedora >= 30 is broken)", 2019-05-13) which is pushed to master but not yet to f30.

The jgit test fix will also be in the upcoming 2.22.0 release.  I'm testing git-2.22.0-rc1 now and have to look into unrelated failures on s390x.

Comment 3 Petr Pisar 2019-05-23 15:53:05 UTC

I don't have any historical build.logs. A recent one can be obtained from <https://apps.fedoraproject.org/koschei/package/git> and that's the place I quoted the failure from.

Comment 4 Todd Zullinger 2019-05-26 03:25:38 UTC

With the unrelated build failures on s390x resolved, git-2.22.0-0.2.rc1.fc31 is now built in rawhide.  This includes the fix to skip jgit tests when jgit is horribly broken.  Once 2.22.0 is final I will merge the changes to f30.