Bug 171350

Created attachment 120208 [details]
Yahoo chatroom ignore on join is not clean

This doesn't trip on linux, but does so on *BSD and Win32. It's best to replace
the code so it does it properly.

Created attachment 120209 [details]
This should make Italian Yahoo profiles work better

The patch in gaim's cvs for oldstatus is meant to the same as for their 2.x
development, but it isn't. This is the head patch, and should (in theory) work
against oldstatus.

Created attachment 120210 [details]
Properly strip HTML from yahoo status messages

Occasionally, HTML would appear in an away message on yahoo. This patch fixes
that.

Created attachment 120212 [details]
xmlnode.c cleanup

"This is a little cleaner" or "some fixes from head". Take you pick on the
intention here.

Created attachment 120214 [details]
Fix crashes due to non terminate strings

sf patch #1252769, from Federico Schwindt
Fix crashes due to non terminate strings

Created attachment 120215 [details]
Silc: multple patches: Close gaim_request windows if prpl disconnects

Backport some SILC changes kingant made.  Basically it just uses gc as the
handler in a bunch of gaim_request calls so that the gaim_request window is
closed if the PRPL is disconnected.

Created attachment 120216 [details]
Silc: multple patches: Close gaim_request windows if prpl disconnects

Backport some SILC changes kingant made.  Basically it just uses
gc as the handler in a bunch of gaim_request calls so that the
gaim_request window is closed if the PRPL is disconnected.

Created attachment 120217 [details]
Silc: multple patches: Close gaim_request windows if prpl disconnects

Silc: multple patches: Close gaim_request windows if prpl disconnects

Created attachment 120218 [details]
Silc: multple patches: Close gaim_request windows if prpl disconnects

Silc: multple patches: Close gaim_request windows if prpl disconnects

Created attachment 120219 [details]
Silc: multple patches: Close gaim_request windows if prpl disconnects

Silc: multple patches: Close gaim_request windows if prpl disconnects

Created attachment 120220 [details]
Silc: multple patches: Close gaim_request windows if prpl disconnects

Silc: multple patches: Close gaim_request windows if prpl disconnects

Created attachment 120221 [details]
MSN prpl data corruption fix

Patch #1270451 from Charlie Gordon

"when write needs to be called several times to output
 the buffer, the data actually written is corrupted"

This was a one-liner and looked correct to rlaager

Created attachment 120222 [details]
MSN prpl: multiple patches: Kill convo close/timeout notices, fix for ACK

Kill off the conversation closed and timed-out notices

Fix for setting the ACK id on slpmsg ACKs which might improve things for
other clients (see bug #1222320)

Created attachment 120223 [details]
MSN prpl: multiple patches: Kill convo close/timeout notices, fix for ACK

Kill off the conversation closed and timed-out notices

Fix for setting the ACK id on slpmsg ACKs which might improve things for
other clients (see bug #1222320)

Created attachment 120224 [details]
MSN prpl: multiple patches: Kill convo close/timeout notices, fix for ACK

Kill off the conversation closed and timed-out notices

Fix for setting the ACK id on slpmsg ACKs which might improve things for
other clients (see bug #1222320)

Created attachment 120225 [details]
Forceful connetion_disconnect shouldn't wipe the password

gaim_connection_disconnect() will wipe the password, which is usually fine, but
when we're knocked off forecfully, we'll want to reconnect easily.

Created attachment 120226 [details]
gtkimhtml: fix clipboard leak and history scroll problems

Fix a clipboard memory leak, no more history plugin not
scrolling to the bottom problems.

Created attachment 120228 [details]
core/ui: multiple patches: Correct smileys, regardless of log type

Thanks to Richard Laager, our log files will be considerably shorter and
we'll be able to see the correct smileys, regardless of log type.

Created attachment 120229 [details]
core/ui: multiple patches: Correct smileys, regardless of log type

Thanks to Richard Laager, our log files will be considerably shorter and
we'll be able to see the correct smileys, regardless of log type.

Created attachment 120230 [details]
IRC: Italics support

Apparently at some point eblanton wrote italic support for IRC and never
committed it

can we just cc: the gaim-commits mailing list to this bug with a filter on
"oldstatus".
really, I don't understand what the point of this is, especially why is it
"security" severity?

Created attachment 120232 [details]
Authors update

Created attachment 120233 [details]
copyright update

Created attachment 120234 [details]
coding for gaim info patch

Created attachment 120235 [details]
Dox creation fix

I think that should largely do you. There may be some OSCAR or Jabber fixes that
you should ahve, but at the moment they're buried in bad commit messages.
Additionally, I haven't provided patches for the new OSCAR file transfer, as I
believe new funcitonality is not required with this patchset (hence, I didn't
remove rendevouz and place bonjour in instead, nor update the translations or
for that matter the win32 changes).

Feel free to try and contact me on freenode for any queries.

There's that good fix in the Yahoo! PRPL to avoid putting HTML markup in your
away message when you become idle.

KingAnt: "There's" as in, "there is also", or "oh, hello, there is my good fix"?

Stu: I was asked to grab all sever patches, plus others that may be worthwhile.
After discussing with warren, we decided we could shove them all into the one
bugzilla report. There's no 'catchall' severity, and I didn't know what to set
it to, as some are severe, some are minor.

Peter Lawler: Oh, sorry, I guess I meant "There's" as in "I'm an idiot and
didn't notice that you had already attached the Yahoo patch, even though I
looked through everything.  I'm blind."

Thank you for the effort Peter, but unfortunately I am way too exhausted now to
do  this before I sleep.  I promise to do this first thing at work tomorrow.

http://cvs.sourceforge.net/viewcvs.py/gaim/gaim/src/protocols/oscar/oscar.c?r1=1.663.2.39&r2=1.663.2.40&diff_format=u
AIM rate limiting error patch

I realized that many of these patches are from HEAD and will likely never go
into oldstatus branch.  I don't feel comfortable about forking and this becoming
a maintenance nightmare into the future.  So I asked Luke which are the most
important to include:

<LSchiere2> the silc patches, if they apply.  #12, #13-15, 22 & 23, and 32

The patches from HEAD tended to have 'a quick fix' style comment on the HEAD
commit, and 'backport from HEAD' comment on the oldstatus commit. All patches
are from cvs oldstatus (except for the ones missing Index, where I was too lazy
to use cvs and used SF's webcvs instead)

Apologies for skipping one of the more important ones (AIM limit)

It'd be nice to be able to read the details of what this is blocking

What is going on with this? I spent a day of my time to do your work for you,
and I informed others that an updated gaim 1.5.0 would come out on Fedora. Now
I'm looking like a liar!

I am the liar. =(
I completely fell on my face and burned out for a while there.  I think I can
get to this today.

The only patch here that doens't apply against gaim-1.5.0 is Comment #2 for
Italian profiles.  How important is this?  Should I just drop it?

I guess that depends on how many Italian users have posted bugs about not being
able to view profiles.

nosnilmot rediffed it and it has been applied:
http://cvs.fedora.redhat.com/viewcvs/devel/gaim/gaim-1.5.0-it-yahoo_profile.patch?rev=1.1&view=log

gaim-1.5.0-9.fc3 and gaim-1.5.0-9.fc4 have been pushed to FC3 and FC4 updates.

Awesome

Top stuff.

Issued in FC3, FC4 and FC5, and soon RHEL3/RHEL4.