Bug 1713967

Created attachment 1573703 [details]
screenshot

logs?

(In reply to Michal Skrivanek from comment #2)
> logs?

Hi Michal, which logs will help? the issue is pretty strait forward. Have a 4.3.4.1-0.1 engine and press the dash board.

it's good that it's straightforward, but noone will get to install it for few days. logs always help. 
sosreport from the engine would be good

it needs to be clarified(the exact steps of upgrade/sosreport) and reproduced in a clean environment

(In reply to Michal Skrivanek from comment #8)
> it needs to be clarified(the exact steps of upgrade/sosreport) and
> reproduced in a clean environment

Clean + upgrade

Michael, can you please also attach ovirt-engine-dwhd logs?

Can you provide a copy and paste from the browser console? It would help to see the JavaScript error.

Indeed it is https://gerrit.ovirt.org/#/c/98545/

DataProvider.js:35 DataProvider failed to fetch data TypeError: Cannot read property 'forEach' of undefined
at DashboardDataProvider.js:80
at Array.forEach (<anonymous>)
at i (DashboardDataProvider.js:76)


line 80:
    heatMapData.forEach(obj => {
      obj.value = obj.value / 100
    })


I suspect heatMapData is undefined for 'vdoSavings' sometimes.

(In reply to Greg Sheremeta from comment #16)
> Indeed it is https://gerrit.ovirt.org/#/c/98545/
> 
> DataProvider.js:35 DataProvider failed to fetch data TypeError: Cannot read
> property 'forEach' of undefined
> at DashboardDataProvider.js:80
> at Array.forEach (<anonymous>)
> at i (DashboardDataProvider.js:76)
> 

The patch that adds 'vdoSavings' [1] wasn't back-ported to 4.3. See BZ1656683.  With [2] in dashboard, the way the dashboard DataProvider post processes data from the dashboard service does not include a check to make sure each data element exists. So as it is trying to process 'vdoSavings' data, the data key doesn't exist and we see the error above.

I recommend two quick followups.  First, I can add some existence checking to the dashboard data post processor so data that is missing won't cause the entire process to fail.  This will allow dashboard to function but will leave any components/charts that rely on missing data to either not render or render empty.  Second, the patch [2] should be back-ported to the appropriate 4.3 branch.

[1] https://gerrit.ovirt.org/#/c/96830/
[2] https://gerrit.ovirt.org/#/c/98545/

Hm... I have several VDOs and the logic points me that my DWH should have the necessary data in order to visualize everything needed.
Does this bug only affect engines with VDOs ?

(In reply to Strahil Nikolov from comment #19)
> Hm... I have several VDOs and the logic points me that my DWH should have
> the necessary data in order to visualize everything needed.
> Does this bug only affect engines with VDOs ?

No, this bug effects all engines.

BZ1656683 needed to be backported (which is already nearly done: https://gerrit.ovirt.org/100375) for the current ui-extensions / dashboard code to render properly.

https://gerrit.ovirt.org/#/c/100380/ enhances the dashboard code itself to handle if data is missing when fetched from the engine.

You can ping me , if you need further testing.

Verified on ovirt-engine-4.3.4.2-0.1.el7.noarch with ovirt-engine-webadmin-portal-4.3.4.2-0.1.el7.noarch

This bugzilla is included in oVirt 4.3.4 release, published on June 11th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.