Bug 171504 (kipi-plugins)
| Summary: | Review Request: kipi-plugins: Plugins to use with Kipi | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, mgarski |
| Target Milestone: | --- | Flags: | wtogami:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://extragear.kde.org/apps/kipi/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-10-22 15:07:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Rex Dieter
2005-10-21 21:35:47 UTC
* The release tag should be 0.1.rc1 according to the package naming guidelines
* Some lines in the description tag are too long.
* Just a question : what's the test in "make install%{!?debug_package:-strip}" for ?
> Just a question : what's the test in "make install%{!?debug_package:-strip}" for ?
It's for those systems that don't create -debuginfo packages (legacy/old
versions of rpm or those folks who don't have redhat-rpm-config installed). Not
much use for that anymore, so I'll probably just remove it for the next package
iteration.
%changelog * Tue Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.1.1-0.2.rc1 - Release < 1, since it's not final - Drop Req: dcraw (not available from FE... yet) - Drop Req: kdebase (too big to be mandatory) - %%description: format < 80 columns, mention extra Reqs for some plugins. - drop goofy install-strip conditional Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kipi-plugins-0.1.0-0.2.rc1.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kipi-plugins-0.1.0-0.2.rc1.src.rpm Review for release 0.2.rc1: * RPM name is OK * Source kipi-plugins-0.1.0-rc1.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of kipi-plugins looks OK * File list of kipi-plugins looks OK * Works fine. APPROVED Thanks, importing now. Package Change Request ====================== Package Name: kipi-plugins Updated Fedora Owners: gauret mgarski Is the intention to add comaintainers or a change of package ownership? Please clarify and set fedora-cvs to '?' again. Crap, good catch. (: Package Change Request ====================== Package Name: kipi-plugins Updated Fedora Cc: gauret mgarski +comaintainers. We (gauret and mgarski) has not been added as cc list, but as a initial owners of bugs, which is wrong. That should be changed. :) |