Bug 1715429

Summary: [machines]Operations for transient networks will cause an Ooops
Product: Red Hat Enterprise Linux 8 Reporter: YunmingYang <yunyang>
Component: cockpit-appstreamAssignee: Katerina Koukiou <kkoukiou>
Status: CLOSED ERRATA QA Contact: YunmingYang <yunyang>
Severity: low Docs Contact:
Priority: unspecified    
Version: 8.1CC: leiwang, mpitt, wshi, xchen
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.2   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 15:42:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description YunmingYang 2019-05-30 10:32:10 UTC
Description of problem:
Though cockpit-machines doesn't support transient resources, there is no button to create an network, so maybe user will create network by command.If they use 'virsh create ${net_xml}', the Ooops will  be shown on the page after clicking 'Deactivate' button


Version-Release number of selected component (if applicable):
cockpit-machines-193-1.el8.noarch
libvirt-dbus-1.2.0-2.module+el8.1.0+2983+b2ae9c0a.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Create an network with using command which is 'virsh net-create ${net_xml}'
2. Click 'Deactivate' button of the network on the page

Actual results:
1. There will be an Ooops shown on the page

Expected results:
1. Maybe there can be an notification which likes that 'cockpit-machines' doesn't support 'transient resources'

Additional info:

The error message which is shown on the web console:

Uncaught TypeError: Cannot read property 'v' of undefined
    at Function.<anonymous> (machines.js:59)
    at s (cockpit.js:963)
    at cockpit.js:975
    at n (cockpit.js:881)

Comment 1 Katerina Koukiou 2019-11-26 09:07:31 UTC
Fixed upstream by:

commit 160dbcc044fa525558f19d153305d3ba3ee5c62c
Author: Simon Kobyda <42733240+skobyda.github.com>
Date:   Tue Nov 26 09:35:52 2019 +0100

    machines: Support transient virtual networks and storage pools
    
    Fixed https://bugzilla.redhat.com/show_bug.cgi?id=1715429

    Closes #13165

Comment 3 Martin Pitt 2019-12-06 06:43:45 UTC
@Xianghua: Done. @Katerina: Please use "POST" status after you land a fix. I'll move to MODIFIED once all acks are present and target release is set. Thanks!

Comment 7 Xianghua Chen 2019-12-23 07:58:41 UTC
Verified with packages:
cockpit-machines-209-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

Steps:
1. Prepare a transient network by: virsh net-create {net.xml} 
xml content: 
<network>
  <name>test</name>
  <forward mode='nat'>
    <nat>
      <port start='1024' end='65535'/>
    </nat>
  </forward>
  <ip address='192.168.1.1' netmask='255.255.255.0'>
    <dhcp>
      <range start='192.168.1.2' end='192.168.1.254'/>
    </dhcp>
  </ip>
</network>
2. Enter the cockpit-machines networks page, click "Deactivate" for the new created transient network interface.
1). The 'Delete' button is gray
2). If moving mouse to the 'Delete button', there will be an notification, which is 'Non-persistent network cannot be deleted. It ceases to exists when it's deactivated.' 
3). The new created transient network interface cease to exist once deactivated and disappears on host by checking : #virsh net-list --all

So verified.

Comment 9 errata-xmlrpc 2020-04-28 15:42:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639