Bug 171580

Summary: Review Request: gperiodic
Product: [Fedora] Fedora Reporter: Eric Tanguy <eric.tanguy>
Component: Package ReviewAssignee: Adrian Reber <adrian>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://koti.welho.com/jfrantz/software/gperiodic.html
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-11-09 21:17:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    
Attachments:
Description Flags
spec patch none

Description Eric Tanguy 2005-10-23 18:00:43 UTC 
Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/gperiodic.spec
SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/gperiodic-2.0.8-1.src.rpm
Description: Gperiodic displays a periodic table of the elements, allowing you to
browse through the elements, and view detailed information about each
element.
Comment 1 Adrian Reber 2005-10-24 09:51:23 UTC 
- debuginfo package is empty
- unnecessary "Requires: gtk2"
- .desktop file wrong encoding, typo in categories
- empty and unnecessary files in %doc
- RPM_OPT_FLAGS not honoured

I will atach a patch fixing these problems.
Comment 2 Adrian Reber 2005-10-24 09:53:07 UTC 
Created attachment 120301 [details]
spec patch
Comment 3 Eric Tanguy 2005-10-24 10:18:59 UTC 
Ok Thanks.
Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/gperiodic.spec
SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/gperiodic-2.0.8-2.src.rpm
Comment 4 Eric Tanguy 2005-10-25 10:32:24 UTC 
Could you explicitly approve the new package or ask for more modifications, 
please.
Comment 5 Adrian Reber 2005-10-30 19:55:41 UTC 
* builds in mock
* clean installation and removal
* source matches upstream
* spec looks good
* lang macro used
* no scripts to check
* works as expected

APPROVED