Bug 1715887

Summary:	fix nmcli resetting default value for connection
Product:	Red Hat Enterprise Linux 7	Reporter:	Thomas Haller <thaller>
Component:	NetworkManager	Assignee:	Thomas Haller <thaller>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.7	CC:	atragler, bgalvani, fgiudici, jomurphy, lrintel, pasik, rkhan, sukulkar, thaller, vbenes
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	NetworkManager-1.18.4-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-31 20:07:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Thomas Haller 2019-05-31 14:04:22 UTC

Requesting backport for upstream fix https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/403f207fe58538f0228ac42918f23d2e6a18e8b6


This bug was introduced in 1.18.0, and affects rhel-7.7.



This affects connection properties that don't have a default value of 0/FALSE/NULL. When trying to reset the value with nmcli, it was wrong.

For example 

  $ nmcli connection modify "$PROFILE" connection.autoconnect ''
  $ nmcli -f connection.autoconnect connection show "$PROFILE" 
  connection.autoconnect:                 no

  ("yes" would be correct).

  $ nmcli connection modify "$PROFILE" connection.autoconnect-retries ''
  $ nmcli -f connection.autoconnect-retries connection show "$PROFILE" 
  connection.autoconnect-retries:         0 (forever)

  (-1 would be correct).


The patch itself is trivial, hence I would fix this in rhel-7.7.

Comment 4 sushil kulkarni 2019-06-19 13:29:45 UTC

Resetting blocker per PM review. Will fix in 7.8.

-Sushil

Comment 6 Thomas Haller 2019-10-09 09:30:26 UTC

also fixed on nm-1-18 branch: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/2a2a66b4d5de87a73ea14c9e5d24963ae0eec236

Comment 8 Vladimir Benes 2019-10-21 13:39:37 UTC

We are checking that all values can be set now.. from 0 to 6. Test added.

Comment 9 Vladimir Benes 2019-10-21 13:41:08 UTC

(In reply to Vladimir Benes from comment #8)
> We are checking that all values can be set now.. from 0 to 6. Test added.

ah, the wrong bug, this one is about adding a test and verification of resetting values with an empty string. This is done and working well.

Comment 11 errata-xmlrpc 2020-03-31 20:07:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1162