Bug 1715890

Summary: should throw redhat-menus into a ditch
Product: Red Hat Enterprise Linux 8 Reporter: Martin Krajnak <mkrajnak>
Component: gnome-menusAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact:
Priority: unspecified    
Version: 8.1CC: jkoten, mboisver, rstrode, tpelka
Target Milestone: rc   
Target Release: 8.1   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gnome-menus-3.13.3-11.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 16:09:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Krajnak 2019-05-31 14:16:51 UTC
Description of problem:
Since it's compulsory for all packaged to have gating tests, several files are not passing desktop-file-validate check with errors. Tests are inspired by gating tests for gnome-menus, therefore I hope it also applies fot the redhat-menus that the files should pass the desktop-file-validate check.


Version-Release number of selected component (if applicable):
redhat-menus-12.0.2-12.el8.noarch

How reproducible:
always

Steps to Reproduce:
for file in ${rpm -ql | grep .directory}
   desktop-file-validate $file

Actual results:
desktop-file-validate /usr/share/desktop-directories/Advanced-More.directory

/usr/share/desktop-directories/Advanced-More.directory: error: (will be fatal in the future): value "advanced-directory.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
/usr/share/desktop-directories/Advanced-More.directory: warning: key "Encoding" in group "Desktop Entry" is deprecated

desktop-file-validate /usr/share/desktop-directories/Advanced.directory

/usr/share/desktop-directories/Advanced.directory: error: (will be fatal in the future): value "advanced-directory.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
/usr/share/desktop-directories/Advanced.directory: warning: key "Encoding" in group "Desktop Entry" is deprecated


desktop-file-validate /usr/share/desktop-directories/Sawfish.directory

/usr/share/desktop-directories/Sawfish.directory: error: (will be fatal in the future): value "sawfish-group.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path


 desktop-file-validate /usr/share/desktop-directories/ServerConfig-More.directory

/usr/share/desktop-directories/ServerConfig-More.directory: warning: boolean key "Terminal" in group "Desktop Entry" has value "0", which is deprecated: boolean values should be "false" or "true"
/usr/share/desktop-directories/ServerConfig-More.directory: error: key "Terminal" is present in group "Desktop Entry", but the type is "Directory" while this key is only valid for type "Application"

desktop-file-validate /usr/share/desktop-directories/ServerConfig.directory

/usr/share/desktop-directories/ServerConfig.directory: warning: boolean key "Terminal" in group "Desktop Entry" has value "0", which is deprecated: boolean values should be "false" or "true"
/usr/share/desktop-directories/ServerConfig.directory: error: key "Terminal" is pres

desktop-file-validate /usr/share/desktop-directories/SystemConfig-More.directory

/usr/share/desktop-directories/SystemConfig-More.directory: warning: boolean key "Terminal" in group "Desktop Entry" has value "0", which is deprecated: boolean values should be "false" or "true"
/usr/share/desktop-directories/SystemConfig-More.directory: warning: key "Encoding" in group "Desktop Entry" is deprecated
/usr/share/desktop-directories/SystemConfig-More.directory: error: key "Terminal" is present in group "Desktop Entry", but the type is "Directory" while this key is only valid for type "Application"


 desktop-file-validate  /usr/share/desktop-directories/SystemConfig.directory

/usr/share/desktop-directories/SystemConfig.directory: warning: boolean key "Terminal" in group "Desktop Entry" has value "0", which is deprecated: boolean values should be "false" or "true"
/usr/share/desktop-directories/SystemConfig.directory: warning: key "Encoding" in group "Desktop Entry" is deprecated
/usr/share/desktop-directories/SystemConfig.directory: error: key "Terminal" is present in group "Desktop Entry", but the type is "Directory" while this key is only valid for type "Application

Expected results:


Additional info:

Comment 1 Ray Strode [halfline] 2019-06-17 18:11:05 UTC
i'm pretty sure we shouldn't be shipping redhat-menus at all. gnome-menus ships its own directory files and those are the ones we use.

To avoid breaking upgrades we should make gnome-menus Obsoletes/Provides: redhat-menus instead of Requires: it

and to be conservative we should ship a symlink from /etc/xdg/menus/gnome-applications.menu to /etc/xdg/menus/applications.menu for backward compat in case someone is installing xfce from epel or something.

Comment 5 Michael Boisvert 2019-12-17 16:24:54 UTC
I can verify that redhat-menus was thrown into a ditch.

Comment 7 errata-xmlrpc 2020-04-28 16:09:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:1766