Bug 1716145

Summary:	Package autocompletion files for cheat
Product:	[Fedora] Fedora	Reporter:	Jannik <me>
Component:	cheat	Assignee:	Tomas Korbar <tkorbar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	30	CC:	tkorbar
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	cheat-2.5.1-2.fc30 cheat-2.5.1-3.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-11 00:57:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jannik 2019-06-02 10:52:47 UTC

The cheat package in Fedora does currently not contain the autocompletion files that are included upstream: https://github.com/cheat/cheat/tree/master/cheat/autocompletion

For better user experience, I suggest including them into the cheat package and installing them where they belong.

E.g. the cheat.fish autocompletion would need to go into /usr/share/fish/vendor_completions.d. The cheat.bash autocompletion probably belongs to /usr/share/bash-completion/completions/ (but w/o the file extension?!). No idea where zsh stores its completions.

Comment 1 Tomas Korbar 2019-06-06 12:11:27 UTC

Hi Jannik,
Thanks for reporting this issue. I will fix it as soon as possible.

Comment 2 Fedora Update System 2019-06-17 09:22:02 UTC

FEDORA-2019-7dd8b92274 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7dd8b92274

Comment 3 Fedora Update System 2019-06-17 18:17:26 UTC

cheat-2.5.1-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7dd8b92274

Comment 4 Fedora Update System 2019-06-27 00:54:42 UTC

cheat-2.5.1-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 5 Jannik 2019-06-27 08:30:47 UTC

Hi Tomas,

thanks for packaging the completions files.

Unfortunately, something went wrong with the fish completion.

The package contains the file /usr/share/fish/vendor-completions.d/cheat.fish but it actually should be /usr/share/fish/vendor_completions.d/cheat.fish

Notice the _ instead of the - in vendor_completions.d.

Therefore, fish is currently unable to find the completion file.

Could you fix that?

Comment 6 Tomas Korbar 2019-06-27 10:47:14 UTC

Hi Jannik,
Well that is pretty unfortunate. I will update rawhide and f30 as soon as possible.
Excuse my mistake.

Comment 7 Fedora Update System 2019-07-01 13:43:03 UTC

FEDORA-2019-6ae2802963 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6ae2802963

Comment 8 Tomas Korbar 2019-07-01 13:45:55 UTC

Hi Jannik,
This time i will learn from my mistakes and ask you if you would please test new update and its functionality:)

Comment 9 Jannik 2019-07-01 16:48:29 UTC

Cool, thank you.

Of course, I will test this as soon as it hits updates-testing.

Comment 10 Fedora Update System 2019-07-03 02:26:28 UTC

cheat-2.5.1-3.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6ae2802963

Comment 11 Jannik 2019-07-03 15:51:50 UTC

Yep, that works. Tested and left karma.

Thank you!

Comment 12 Fedora Update System 2019-07-11 00:57:40 UTC

cheat-2.5.1-3.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.