Bug 1716519
| Summary: | python-rebulk fails to build with Python 3.8 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | python-rebulk | Assignee: | Juan Orti <jorti> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jortialc, jorti, pviktori |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-rebulk/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-07-23 15:00:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1686977 | ||
|
Description
Miro Hrončok
2019-06-03 14:39:51 UTC
============================= test session starts ==============================
platform linux -- Python 3.8.0a4, pytest-4.4.1, py-1.8.0, pluggy-0.11.0
rootdir: /builddir/build/BUILD/rebulk-0.9.0, inifile: pytest.ini
collected 163 items
README.rst . [ 0%]
rebulk/rebulk.py . [ 1%]
rebulk/utils.py . [ 1%]
rebulk/test/test_chain.py ............. [ 9%]
rebulk/test/test_debug.py ...F. [ 12%]
rebulk/test/test_introspector.py .... [ 15%]
rebulk/test/test_loose.py ...... [ 19%]
rebulk/test/test_match.py .......................... [ 34%]
rebulk/test/test_pattern.py ............................................ [ 61%]
... [ 63%]
rebulk/test/test_processors.py .............. [ 72%]
rebulk/test/test_rebulk.py ..................... [ 85%]
rebulk/test/test_rules.py ........... [ 92%]
rebulk/test/test_toposort.py ......... [ 97%]
rebulk/test/test_validators.py .... [100%]
=================================== FAILURES ===================================
____________________________ TestDebug.test_rebulk _____________________________
self = <rebulk.test.test_debug.TestDebug object at 0x7f7ff26d59a0>
def test_rebulk(self):
"""
This test fails on travis CI, can't find out why there's 1 line offset ...
"""
assert self.rebulk._patterns[0].defined_at.lineno in [26, 27]
assert self.rebulk._patterns[0].defined_at.name == 'rebulk.test.test_debug'
assert self.rebulk._patterns[0].defined_at.filename.endswith('test_debug.py')
assert str(self.rebulk._patterns[0].defined_at) in ['test_debug.py#L26', 'test_debug.py#L27']
> assert self.rebulk._patterns[1].defined_at.lineno in [27, 28]
E AssertionError: assert 26 in [27, 28]
E + where 26 = test_debug.py#L26.lineno
E + where test_debug.py#L26 = <StringPattern#L26:('is',)>.defined_at
rebulk/test/test_debug.py:73: AssertionError
Fixed with new version in rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1285461 Unfortunately, update to rebulk 1.0.0 does not ix the problem. Rahide is still on 3.7, we do 3.8 rebuilds in Copr.
=================================== FAILURES ===================================
____________________________ TestDebug.test_rebulk _____________________________
self = <rebulk.test.test_debug.TestDebug object at 0x7f5ead51dfa0>
def test_rebulk(self):
"""
This test fails on travis CI, can't find out why there's 1 line offset ...
"""
assert self.rebulk._patterns[0].defined_at.lineno in [26, 27]
assert self.rebulk._patterns[0].defined_at.name == 'rebulk.test.test_debug'
assert self.rebulk._patterns[0].defined_at.filename.endswith('test_debug.py')
assert str(self.rebulk._patterns[0].defined_at) in ['test_debug.py#L26', 'test_debug.py#L27']
> assert self.rebulk._patterns[1].defined_at.lineno in [27, 28]
E AssertionError: assert 26 in [27, 28]
E + where 26 = test_debug.py#L26.lineno
E + where test_debug.py#L26 = <StringPattern#L26:('is',)>.defined_at
rebulk/test/test_debug.py:73: AssertionError
===================== 1 failed, 162 passed in 1.38 seconds =====================
Full logs: https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00934283-python-rebulk/
How to build in mock: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/
Reported upstream: https://github.com/Toilal/rebulk/issues/18 Tests disabled for now: https://koji.fedoraproject.org/koji/taskinfo?taskID=36229715 Thank you! |