Bug 1716579

Summary:	Review Request: rust-envsubst - A simple Rust library for variables substitution
Product:	[Fedora] Fedora	Reporter:	Robert Fairley <rfairley>
Component:	Package Review	Assignee:	Artem <ego.cordatus>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dustymabe, ego.cordatus, igor.raits, lucab, package-review, rfairley
Target Milestone:	---	Flags:	ego.cordatus: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-09 16:05:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert Fairley 2019-06-03 17:08:32 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-envsubst/fedora-rawhide-x86_64/00920421-rust-envsubst/rust-envsubst.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-envsubst/fedora-rawhide-x86_64/00920421-rust-envsubst/rust-envsubst-0.1.0-1.fc31.src.rpm
Description: A simple Rust library for variables substitution.
Fedora Account System Username: rfairley

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35251980

Dependency of Zincati [1] which is to be packaged for FCOS [2]

[1] https://github.com/coreos/zincati
[2] https://github.com/coreos/fedora-coreos-tracker/issues/190

Comment 1 Robert Fairley 2019-06-04 13:17:39 UTC

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35252171

Comment 2 Robert Fairley 2019-06-04 13:18:41 UTC

Apologies - disregard previous comment (https://bugzilla.redhat.com/show_bug.cgi?id=1716579#c1).

Comment 3 Artem 2019-06-06 16:18:49 UTC

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

! No license file, otherwise OK.

Package approved.

Comment 4 Igor Raits 2019-06-09 15:18:40 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-envsubst