Bug 1716886
| Summary: | Review Request: nordugrid-arc6 - Advanced Resource Connector Middleware (version 6 for EPEL 7) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Andrea <andrea.manzi> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel7 | CC: | andrea.manzi, package-review |
| Target Milestone: | --- | Flags: | andrea.manzi:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-07-14 02:30:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mattias Ellert
2019-06-04 10:59:36 UTC
Hi Mattias, maybe you have already done it by yourself, but i'm running the fedora-review tool and i will post the result when done. cheers Andrea i have uploaded the report at https://cernbox.cern.ch/index.php/s/sxWWXjaqRE3W7SC i will need to manual review it, but maybe you can already see some possible issues there just few errors from rpmlint https://fedoraproject.org/wiki/Common_Rpmlint_issues#incoherent-logrotate-file for: nordugrid-arc6-arex.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/nordugrid-arc-arex nordugrid-arc6-infosys-ldap.noarch: E: incoherent-logrotate-file /etc/logrotate.d/nordugrid-arc-infosys-ldap nordugrid-arc6-datadelivery-service.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/nordugrid-arc-datadelivery-service nordugrid-arc6-gridftpd.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/nordugrid-arc-gridftpd and zero-length files https://fedoraproject.org/wiki/Common_Rpmlint_issues#zero-length for nordugrid-arc6.x86_64: E: zero-length /usr/lib64/arc/libmodcredential.apd nordugrid-arc6.x86_64: E: zero-length /usr/lib64/arc/libmodcrypto.apd Thank you for reviewing this. Regarding the incoherent-logrotate-file remarks: As stated in the initial review request, this is a new version of an existing package where the packages from this package conflicts with the packages from the old version. This package was created with minimal changes w.r.t. the original package, and the names of the logrotate files (that were based on the old package names) were not changed. Since no other filenames were changed, it seems inconsistent to change the names of logrotate files. Regarding the zero-length remarks: This are not errors. All the loadable modules have an .apd file listing what loadable functionality they provide. These 2 are a bit special in that they are explicitly loaded when needed by other modules and therefore the functionality does not need to be listed. ok thanks for the clarification, i have marked the fedora-review flag to +, so everything is fine from my side. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nordugrid-arc6 FEDORA-EPEL-2019-37f83b7716 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-37f83b7716 nordugrid-arc6-6.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-37f83b7716 nordugrid-arc6-6.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |