Bug 1717090

Summary: libvirt-5.4.0/tests/testutilsqemu.c:921]: (style) Suspicious condition
Product: [Community] Virtualization Tools Reporter: David Binderman <dcb314>
Component: libvirtAssignee: Erik Skultety <eskultet>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: eskultet, libvirt-maint, tburke
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-04 19:02:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2019-06-04 16:51:44 UTC 
Description of problem:

libvirt-5.4.0/tests/testutilsqemu.c:921]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
85a250

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Source code is

  while ((rc = virDirRead(dir, &ent, TEST_QEMU_CAPS_PATH) > 0)) {

Maybe better code:

  while ((rc = virDirRead(dir, &ent, TEST_QEMU_CAPS_PATH)) > 0) {
Comment 1 Erik Skultety 2019-06-04 19:02:35 UTC 
Fixed upstream by:
commit 08ad83eee133d6bac27865d9321e399db7bbe29e
Refs: v5.4.0-49-g08ad83eee1
Author:     Erik Skultety <eskultet>
AuthorDate: Tue Jun 4 20:56:58 2019 +0200
Commit:     Erik Skultety <eskultet>
CommitDate: Tue Jun 4 20:56:58 2019 +0200

    tests: Fix parentheses order in an assignment-comparison conditional

    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1717090

    Signed-off-by: Erik Skultety <eskultet>