Bug 1717640

Summary: clusteroperator/storage does not define any related resources
Product: OpenShift Container Platform Reporter: Luis Sanchez <sanchezl>
Component: StorageAssignee: Fabio Bertinatto <fbertina>
Status: CLOSED ERRATA QA Contact: Liang Xia <lxia>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.1.0CC: aos-bugs, aos-storage-staff, chaoyang, eparis, fbertina, sponnaga
Target Milestone: ---   
Target Release: 4.1.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: 4.1.6
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-23 18:12:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Luis Sanchez 2019-06-05 20:43:08 UTC
Description of problem:

The storage ClusterOperator resource does not specify any related resources. This hinders problem-determination as tools cannot automatically collect the information needed to debug issues.

The operator should specify, at minimum, a namespace and a configuration resource to collect.

Here is an example from kube-apisever:

kind: ClusterOperator
metadata:
  name: kube-apiserver
status:
  relatedObjects:
    - group: operator.openshift.io
      name: cluster
      resource: kubeapiservers
    - group: ''
      name: openshift-config
      resource: namespaces
    - group: ''
      name: openshift-config-managed
      resource: namespaces
    - group: ''
      name: openshift-kube-apiserver-operator
      resource: namespaces
    - group: ''
      name: openshift-kube-apiserver
      resource: namespaces


A new e2e test designed to catch this deficiency will white-list this component initially. This component should be removed from the white-list as part of resolving this issue.

https://github.com/openshift/origin/blob/master/test/extended/operators/clusteroperators.go (link will be active once https://github.com/openshift/origin/pull/23044 merges)

Comment 1 Fabio Bertinatto 2019-06-20 13:58:32 UTC
Created PR: https://github.com/openshift/cluster-storage-operator/pull/37

Comment 2 Fabio Bertinatto 2019-06-20 15:41:26 UTC
Openshift PR: https://github.com/openshift/origin/pull/23228

Comment 7 Eric Paris 2019-06-27 00:13:36 UTC
The PR in question was reverted as it was merged inappropriately. I will talk with Fabio tomorrow to make sure this does not happen again.

Comment 8 Fabio Bertinatto 2019-06-27 07:46:46 UTC
@paris, I'm sorry for setting the PR labels manually. It was the fist time I cherry-picked a patch and I wasn't aware of the process as I should. I'll be more careful next time.

Comment 10 Fabio Bertinatto 2019-06-28 07:47:37 UTC
Cherry-pick PR: https://github.com/openshift/cluster-storage-operator/pull/40

Comment 13 Liang Xia 2019-07-04 05:20:43 UTC
Verified the issue has been fixed in 4.1.0-0.nightly-2019-07-03-205519

$ oc get co storage -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2019-07-04T01:48:16Z"
  generation: 1
  name: storage
  resourceVersion: "7862"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/storage
  uid: cac267b3-9dfd-11e9-89b9-0ac8fd55befc
spec: {}
status:
  conditions:
  - lastTransitionTime: "2019-07-04T01:48:16Z"
    status: "True"
    type: Available
  - lastTransitionTime: "2019-07-04T01:48:16Z"
    status: "False"
    type: Degraded
  - lastTransitionTime: "2019-07-04T01:48:16Z"
    status: "False"
    type: Progressing
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-cluster-storage-operator
    resource: namespaces
  - group: config.openshift.io
    name: cluster
    resource: infrastructures
  - group: storage.k8s.io
    name: gp2
    resource: storageclasses
  versions:
  - name: operator
    version: 4.1.0-0.nightly-2019-07-03-205519

Comment 15 errata-xmlrpc 2019-07-23 18:12:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1766