Bug 1717655

FAILED: gi/1917d73@@_gi.cpython-38-x86_64-linux-gnu@sha/pygobject-object.c.o 
cc -Igi/1917d73@@_gi.cpython-38-x86_64-linux-gnu@sha -Igi -I../gi -Igi/.. -I../gi/.. -I/usr/include/python3.8 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gobject-introspection-1.0 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -O2 -g -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -pthread -DPY_SSIZE_T_CLEAN -Wall -Warray-bounds -Wcast-align -Wdeclaration-after-statement -Wduplicated-branches -Wextra -Wformat=2 -Wformat-nonliteral -Wformat-security -Wimplicit-function-declaration -Winit-self -Wjump-misses-init -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wnull-dereference -Wold-style-definition -Wpacked -Wpointer-arith -Wrestrict -Wreturn-type -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wundef -Wunused-but-set-variable -Wwrite-strings -Wno-missing-field-initializers -Wno-unused-parameter -Wno-discarded-qualifiers -Wno-sign-conversion -Wno-cast-function-type -Wno-int-conversion -fno-strict-aliasing -fvisibility=hidden -Wswitch-default -MD -MQ 'gi/1917d73@@_gi.cpython-38-x86_64-linux-gnu@sha/pygobject-object.c.o' -MF 'gi/1917d73@@_gi.cpython-38-x86_64-linux-gnu@sha/pygobject-object.c.o.d' -o 'gi/1917d73@@_gi.cpython-38-x86_64-linux-gnu@sha/pygobject-object.c.o' -c ../gi/pygobject-object.c
In file included from /usr/include/python3.8/abstract.h:837,
                 from /usr/include/python3.8/Python.h:147,
                 from ../gi/pygobject-object.h:4,
                 from ../gi/pygobject-object.c:23:
/usr/include/python3.8/cpython/abstract.h: In function '_PyVectorcall_Function':
/usr/include/python3.8/cpython/abstract.h:88:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   88 |     Py_ssize_t offset = tp->tp_vectorcall_offset;
      |     ^~~~~~~~~~
/usr/include/python3.8/cpython/abstract.h:90:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   90 |     vectorcallfunc *ptr = (vectorcallfunc *)(((char *)callable) + offset);
      |     ^~~~~~~~~~~~~~
/usr/include/python3.8/cpython/abstract.h: In function '_PyObject_Vectorcall':
/usr/include/python3.8/cpython/abstract.h:119:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  119 |     vectorcallfunc func = _PyVectorcall_Function(callable);
      |     ^~~~~~~~~~~~~~
/usr/include/python3.8/cpython/abstract.h:124:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  124 |     PyObject *res = func(callable, args, nargsf, kwnames);
      |     ^~~~~~~~
In file included from /usr/include/dirent.h:245,
                 from /usr/include/glib-2.0/glib/gdir.h:32,
                 from /usr/include/glib-2.0/glib.h:45,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from ../gi/pygobject-object.h:5,
                 from ../gi/pygobject-object.c:23:
../gi/pygobject-object.c: In function 'pygobject_inherit_slots':
../gi/pygobject-object.c:881:35: error: 'PyTypeObject' {aka 'struct _typeobject'} has no member named 'tp_print'
  881 |                                   offsetof(PyTypeObject, tp_print) };
      |                                   ^~~~~~~~
[6/56] cc -Igi/1917d73@@_gi_cairo.cpython-38-x86_64-linux-gnu@sha -Igi -I../gi -I/usr/include/python3.8 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gobject-introspection-1.0 -I/usr/include/pycairo -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/uuid -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -O2 -g -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -pthread -DPY_SSIZE_T_CLEAN -Wall -Warray-bounds -Wcast-align -Wdeclaration-after-statement -Wduplicated-branches -Wextra -Wformat=2 -Wformat-nonliteral -Wformat-security -Wimplicit-function-declaration -Winit-self -Wjump-misses-init -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wnull-dereference -Wold-style-definition -Wpacked -Wpointer-arith -Wrestrict -Wreturn-type -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wundef -Wunused-but-set-variable -Wwrite-strings -Wno-missing-field-initializers -Wno-unused-parameter -Wno-discarded-qualifiers -Wno-sign-conversion -Wno-cast-function-type -Wno-int-conversion -fno-strict-aliasing -fvisibility=hidden -Wswitch-default -MD -MQ 'gi/1917d73@@_gi_cairo.cpython-38-x86_64-linux-gnu@sha/pygi-foreign-cairo.c.o' -MF 'gi/1917d73@@_gi_cairo.cpython-38-x86_64-linux-gnu@sha/pygi-foreign-cairo.c.o.d' -o 'gi/1917d73@@_gi_cairo.cpython-38-x86_64-linux-gnu@sha/pygi-foreign-cairo.c.o' -c ../gi/pygi-foreign-cairo.c
In file included from /usr/include/python3.8/abstract.h:837,
                 from /usr/include/python3.8/Python.h:147,
                 from ../gi/pygi-foreign-cairo.c:24:
/usr/include/python3.8/cpython/abstract.h: In function '_PyVectorcall_Function':
/usr/include/python3.8/cpython/abstract.h:88:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   88 |     Py_ssize_t offset = tp->tp_vectorcall_offset;
      |     ^~~~~~~~~~
/usr/include/python3.8/cpython/abstract.h:90:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   90 |     vectorcallfunc *ptr = (vectorcallfunc *)(((char *)callable) + offset);
      |     ^~~~~~~~~~~~~~
/usr/include/python3.8/cpython/abstract.h: In function '_PyObject_Vectorcall':
/usr/include/python3.8/cpython/abstract.h:119:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  119 |     vectorcallfunc func = _PyVectorcall_Function(callable);
      |     ^~~~~~~~~~~~~~
/usr/include/python3.8/cpython/abstract.h:124:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  124 |     PyObject *res = func(callable, args, nargsf, kwnames);
      |     ^~~~~~~~
ninja: build stopped: subcommand failed.
error: Bad exit status from /var/tmp/rpm-tmp.meAGSw (%build)

Fixed upstream: https://gitlab.gnome.org/GNOME/pygobject/merge_requests/119

This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

This issue needs to be resolved by next week, if other rebuilds of Python 3.8 beta 1 go well. If this is unrealistic for you, let us know how much time you need.

If you don't have free cycles to dedicate fixing your package, notify us and we'll try to provide some pointers. Let us know if we can push a fix directly without a pull request, in the case we happen to have one before you do.

We recommend always consulting with upstream, chances are this is already fixed there.

This issue is blocking the Python 3.8 rebuilds. This package is part of the first 500 packages we build to bootstrap everything else. 
Unless this is resolved, we cannot proceed with the side tag rebuilds.

This is needed by anaconda and plenty of others. Please backport the fix.

Patches pushed to rawhide and build started.

Built in rawhide.

Triggered a build in copr.

copr build failed, running again to eliminate random copr related failures

Works. Thank you.