Bug 1718288

Summary:	libnbd fails to build with Python 3.8
Product:	[Fedora] Fedora	Reporter:	Petr Viktorin (pviktori) <pviktori>
Component:	libnbd	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mhroncok, rjones
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-09 20:36:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1686977

Description Petr Viktorin (pviktori) 2019-06-07 12:28:44 UTC

libnbd fails to build with Python 3.8.0b1.

There is no obvious (to me) error in the build logs, but several files end up not being built:
BUILDSTDERR: error: File not found: /builddir/build/BUILDROOT/libnbd-0.1.2-2.fc31.x86_64/usr/lib64/python3.8/site-packages/libnbdmod*.so
BUILDSTDERR: error: File not found: /builddir/build/BUILDROOT/libnbd-0.1.2-2.fc31.x86_64/usr/lib64/python3.8/site-packages/nbd.py
BUILDSTDERR: error: File not found: /builddir/build/BUILDROOT/libnbd-0.1.2-2.fc31.x86_64/usr/lib64/python3.8/site-packages/__pycache__/nbd*.py*
BUILDSTDERR: error: File not found: /builddir/build/BUILDROOT/libnbd-0.1.2-2.fc31.x86_64/usr/bin/nbdsh
BUILDSTDERR: error: File not found: /builddir/build/BUILDROOT/libnbd-0.1.2-2.fc31.x86_64/usr/share/man/man1/nbdsh.1*

Also, this line and several empty test suites suggests you should add `BuildRequires: libndb-devel`:
BUILDSTDERR: configure: WARNING: nbdkit development package is not installed, tests will be disabled


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00925605-libnbd/

For all our attempts to build libnbd with Python 3.8, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/libnbd/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Let us know here if you have any questions.

Comment 1 Richard W.M. Jones 2019-06-07 12:51:16 UTC

I guess the same problem we had in libguestfs because PYTHON_LIBS is no longer defined:

https://www.redhat.com/archives/libguestfs/2019-May/msg00255.html

Comment 2 Richard W.M. Jones 2019-06-09 20:36:38 UTC

I fixed this in libnbd commit 70fa61b407969dec12e85e039fdaca550a12009f
libnbd >= 0.1.3

This will be in Rawhide soon.