Bug 1718332

Summary: python-crypto fails to build with Python 3.8
Product: [Fedora] Fedora Reporter: Petr Viktorin (pviktori) <pviktori>
Component: python-cryptoAssignee: Paul Howarth <paul>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: athmanem, paul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-crypto-2.6.1-26.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-07 17:17:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1686977    

Description Petr Viktorin (pviktori) 2019-06-07 13:35:23 UTC 
python-crypto fails to build with Python 3.8.0b1.

The function time.clock(), used in Crypto/Random/_UserFriendlyRNG.py, has been removed. It was deprecated since Python 3.3. Use time.perf_counter() or time.process_time() instead, depending on your requirements, to have a well defined behavior. 
More info:
https://docs.python.org/3.8/whatsnew/3.8.html#api-and-feature-removals

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00927490-python-crypto/

For all our attempts to build python-crypto with Python 3.8, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-crypto/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Let us know here if you have any questions.
Comment 1 Paul Howarth 2019-06-07 17:17:11 UTC 
I have copied the approach taken in pycryptodome (a fork of pycrypto), dropping the bundled random number generator and replacing it with a thin wrapper to os.urandom. This gets rid of the problematic code.

Fix in pycryptodome:
https://github.com/Legrandin/pycryptodome/commit/afd6328f

There was also some code for Python 2.1 compatibility that Python 3.8 didn't like, so I got rid of that too.