Bug 1718495

Summary: Embedded method doesn't display when creating a new method and adding embedded method at same time.
Product: Red Hat CloudForms Management Engine Reporter: Jeffrey Cutter <jcutter>
Component: UI - OPSAssignee: Dávid Halász <dhalasz>
Status: CLOSED ERRATA QA Contact: Ganesh Hubale <ghubale>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.4CC: bmidwood, dmetzger, ghubale, hkataria, lavenel, mpovolny, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.17 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-12 13:36:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:

Description Jeffrey Cutter 2019-06-08 00:02:22 UTC 
Description of problem:

When creating an Automate method, if you add an embedded method, it does not appear until after saving.  When editing an existing method it does.


Version-Release number of selected component (if applicable):

5.10.4

How reproducible:
Always

Steps to Reproduce:
1. Create a new inline method in CloudForms Automate.
2. Add an embedded method.
3. Note Embedded method(s) not displayed.
Comment 3 Ganesh Hubale 2019-06-27 12:16:09 UTC 
I checked on version: 5.10.6.1.20190621202107_58f5bbc

This issue is still reproducible.
Comment 4 Martin Povolny 2019-07-24 11:44:23 UTC 
Yes, the issue is there.
Comment 5 Martin Povolny 2019-07-24 12:33:40 UTC 
Checked the code, and passing it to David.
Comment 7 CFME Bot 2019-07-24 15:17:25 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/5866
Comment 8 CFME Bot 2019-07-25 10:06:28 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/24b46d5612c49f17733e2c50a86dbe4a30c12b04
commit 24b46d5612c49f17733e2c50a86dbe4a30c12b04
Author:     Dávid Halász <dhalasz>
AuthorDate: Wed Jul 24 11:02:02 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Wed Jul 24 11:02:02 2019 -0400

    Do not build the regex for embedded method when there's no fqname

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1718495

 app/controllers/miq_ae_class_controller.rb | 4 +-
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 9 CFME Bot 2019-07-25 20:56:43 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/b2df270168c0fafcd586d7e83f3e0615efe90ddd
commit b2df270168c0fafcd586d7e83f3e0615efe90ddd
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Thu Jul 25 06:01:56 2019 -0400
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Thu Jul 25 06:01:56 2019 -0400

    Merge pull request #5866 from skateman/inline-method-new

    Do not build the regex for embedded method when there's no fqname

    (cherry picked from commit 33b898d46cbbc151f3b603fca066ac88751293a6)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1718495

 app/controllers/miq_ae_class_controller.rb | 4 +-
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 10 Ganesh Hubale 2019-08-01 13:47:19 UTC 
Fixed!

Verified on version: 5.11.0.17.20190730152352_93b1c30
Comment 12 errata-xmlrpc 2019-12-12 13:36:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199