Bug 1719100

Summary: OSP13 ctlplane-ip-range.yaml does not recognise ctlplane-subnet subsection [BACKPORT]
Product: Red Hat OpenStack Reporter: David Sedgmen <dsedgmen>
Component: openstack-tripleo-validationsAssignee: RHOS Maint <rhos-maint>
Status: CLOSED DUPLICATE QA Contact: nlevinki <nlevinki>
Severity: high Docs Contact:
Priority: unspecified    
Version: 13.0 (Queens)CC: gchamoul, jjoyce, jschluet, slinaber, tvignaud
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-11 10:34:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Sedgmen 2019-06-11 04:56:34 UTC 
Description of problem:
OSP 13 supports subnet configuration on undercloud, but the validation playbook only check the default sections


https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html/director_installation_and_usage/installing-the-undercloud#director-configuration-parameters_subnets
https://github.com/openstack/tripleo-validations/blob/stable/queens/validations/ctlplane-ip-range.yaml

How reproducible:

Constantly 

Steps to Reproduce:
1. Added a subnet configuration to the overcloud config
2. run the validation playbook

Actual results:
[stack@undercloud-0 ~]$ ansible-playbook /usr/share/openstack-tripleo-validations/validations/ctlplane-ip-range.yaml  -i testinv --user stack

PLAY [undercloud] *************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ********************************************************************************************************************************************************************************************
ok: [undercloud-0]

TASK [Get the path of tripleo undercloud config file] *************************************************************************************************************************************************************
ok: [undercloud-0]

TASK [Gather undercloud.conf values] ******************************************************************************************************************************************************************************
ok: [undercloud-0]

TASK [Check the size of the DHCP range for overcloud nodes] *******************************************************************************************************************************************************
fatal: [undercloud-0]: FAILED! => {"changed": false, "msg": "The IP range 192.0.2.5 - 192.0.2.24 contains 20 addresses.\nThis might not be enough for the deployment or later scaling."}
 [WARNING]: Could not create retry file '/usr/share/openstack-tripleo-validations/validations/ctlplane-ip-range.retry'.         [Errno 13] Permission denied: u'/usr/share/openstack-tripleo-
validations/validations/ctlplane-ip-range.retry'


PLAY RECAP ********************************************************************************************************************************************************************************************************
undercloud-0               : ok=3    changed=0    unreachable=0    failed=1   

Expected results:

[stack@undercloud-0 ~]$ ansible-playbook /usr/share/openstack-tripleo-validations/validations/ctlplane-ip-range.yaml  -i testinv --user stack

PLAY [undercloud] *************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ********************************************************************************************************************************************************************************************
ok: [undercloud-0]

TASK [Get the path of tripleo undercloud config file] *************************************************************************************************************************************************************
ok: [undercloud-0]

TASK [Gather undercloud.conf values] ******************************************************************************************************************************************************************************
ok: [undercloud-0]

TASK [Check the size of the DHCP range for overcloud nodes] *******************************************************************************************************************************************************
ok: [undercloud-0]

PLAY RECAP ********************************************************************************************************************************************************************************************************
undercloud-0               : ok=4    changed=0    unreachable=0    failed=0

Additional info:

This works in OSP 14 
https://github.com/openstack/tripleo-validations/blob/stable/rocky/validations/ctlplane-ip-range.yaml
Comment 1 Gaël Chamoulaud 2019-06-11 10:34:20 UTC 

*** This bug has been marked as a duplicate of bug 1719109 ***