Bug 1719132

Summary: grub2: FTBFS in Fedora Rawhide
Product: [Fedora] Fedora Reporter: Igor Raits <igor.raits>
Component: freetypeAssignee: Marek Kašík <mkasik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ajax, caillon+fedoraproject, fmartine, fonts-bugs, gnome-sig, john.j5live, kevin, lkundrak, mclasen, mkasik, pjones, rhughes, rstrode, sandmann, yaneti
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-11 08:02:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Igor Raits 2019-06-11 06:55:36 UTC 
util/grub-gen-asciih.c has:

```c
glyph_idx = FT_Get_Char_Index (face, char_code);                                                        
if (!glyph_idx)                                                                                         
  return;                                                                                               
```

Apparently it returns 0 now, so the ascii.h is broken.

please fix this ASAP so that we can proceed with RPM 4.15.

Once you fix it, please run `fedpkg build --target=f31-rpm` for a build.
Comment 1 Igor Raits 2019-06-11 07:00:59 UTC 
It is probably related to freetype rebase. CCing freetype maintainer.
Comment 2 Igor Raits 2019-06-11 07:06:06 UTC 
I think this might be very related.

    - FreeType now uses the `defaultChar' property of PCF fonts to set
      the  glyph for  the undefined  character  at glyph  index 0  (as
      FreeType already does for all other supported font formats).  As
      a consequence,  the order of  glyphs of  a PCF font  if accessed
      with  FreeType  can  be   different  now  compared  to  previous
      versions.

This change doesn't affect PCF font access with cmaps.
Comment 3 Igor Raits 2019-06-11 07:45:54 UTC 
https://src.fedoraproject.org/rpms/freetype/c/8c479430c9096984745b11916c383b79177605ad?branch=master
Comment 4 Marek Kašík 2019-06-11 10:30:11 UTC 
Thank you for resolving this.