Bug 1719697

Summary: cockpit: The check for detecting whether a proxy should be used is wrong during attaching
Product: Red Hat Enterprise Linux 8 Reporter: Marius Vollmer <mvollmer>
Component: subscription-managerAssignee: candlepin-bugs
Status: CLOSED ERRATA QA Contact: Red Hat subscription-manager QE Team <rhsm-qe>
Severity: low Docs Contact:
Priority: low    
Version: ---CC: csnyder, jsefler, redakkan, wpoteat
Target Milestone: rcKeywords: Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 01:38:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marius Vollmer 2019-06-12 11:16:02 UTC
The code in subscription-manager/cockpit/ takes a different path when calling the AutoAttach method depending on whether a proxy has beebn specified in the dialog or not.

The check for selecting the path is

     if (connection_options.proxy_hostname)

However, connection_options.proxy_hostname is always true since it is a D-Bus Variant.  The code needs to look inside the variant:

    if (connection_options.proxy_hostname.v)

This bug has no effect, the code path for the case with proxy also seems to work when there is no actual proxy config.

Comment 2 Marius Vollmer 2019-08-20 06:28:36 UTC
Fixed here: https://github.com/candlepin/subscription-manager/pull/2112

Comment 5 Marius Vollmer 2020-08-07 14:09:53 UTC
The pull request was merged, thanks!

Comment 6 Rehana 2020-08-11 09:11:02 UTC
(In reply to Marius Vollmer from comment #5)
> The pull request was merged, thanks!

Thanks Marius for the acknowledging the fix. Based on the comment, moving this bug to verified.

Comment 9 errata-xmlrpc 2020-11-04 01:38:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (subscription-manager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4460