Bug 1720110

Summary:	Unable to edit pool that is delete protected
Product:	[oVirt] ovirt-engine	Reporter:	Steven Rosenberg <srosenbe>
Component:	Backend.Core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Polina <pagranat>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.3.2.1	CC:	agajania, amashah, bugs, lleistne, mavital, mgoldboi, michal.skrivanek, mtessun, pagranat, rbarry, Rhev-m-bugs, srosenbe
Target Milestone:	ovirt-4.3.5	Flags:	pm-rhel: ovirt-4.3+
Target Release:	4.3.5.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.5.1	Doc Type:	Bug Fix
Doc Text:	Cause: When changing the template of a pool to a sub-version when the Template and therefore VMs of the pool are delete protected, the pool is no longer editable. Consequence: The pool can no longer be editable because the VMs could not be deleted therefore breaking the pool's functionality. Fix: Now when attempting to modify the template version of a pool when the VMs are delete protected fails with an error. Result: Changing the Template Version of a Pool is no longer allowed which prevents the non editable pool scenario from occurring.	Story Points:	---
Clone Of:	1659161	Environment:
Last Closed:	2019-07-30 14:08:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1659161
Bug Blocks:

Comment 1 RHEL Program Management 2019-06-13 07:32:39 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Polina 2019-06-18 10:57:35 UTC

Tested on ovirt-engine-4.3.5-0.1.el7.noarch.
Steps to Reproduce:

Step 1) Create new template Test1_T from existing VM with Delete Protection enabled.

Step 2) Create pool TestPool from Template Test1_T (base version) with Delete Protection enabled.  Configure Number of VMs=5. Note that Delete Protection setting for TestPool is inherited from the Template.  Leave it enabled.

Step 3) Create new template with Root Template Test1_T and Sub-Version Name 20181212-2. Note that the new template Sub-Version has Delete Protection Enabled.

Step 4) Edit TestPool.  Change the Template to Test1_T Subversion 20181212-2.  

Result: No ERROR.
Though the pool VMs are detached from the pool after this (Stateless is checked for them) and the pool could not be edited again. only Remove option is available for it.

Comment 3 Steven Rosenberg 2019-06-18 11:05:22 UTC

(In reply to Polina from comment #2)
> Tested on ovirt-engine-4.3.5-0.1.el7.noarch.
> Steps to Reproduce:
> 
> Step 1) Create new template Test1_T from existing VM with Delete Protection
> enabled.
> 
> Step 2) Create pool TestPool from Template Test1_T (base version) with
> Delete Protection enabled.  Configure Number of VMs=5. Note that Delete
> Protection setting for TestPool is inherited from the Template.  Leave it
> enabled.
> 
> Step 3) Create new template with Root Template Test1_T and Sub-Version Name
> 20181212-2. Note that the new template Sub-Version has Delete Protection
> Enabled.
> 
> Step 4) Edit TestPool.  Change the Template to Test1_T Subversion
> 20181212-2.  
> 
> Result: No ERROR.
> Though the pool VMs are detached from the pool after this (Stateless is
> checked for them) and the pool could not be edited again. only Remove option
> is available for it.
This issue was recently back ported. Please verify you are using the correct version.

Comment 4 Polina 2019-06-18 11:12:07 UTC

yes, thank you . I see that patch tagged ovirt-engine-4.3.5.1 . 
we only have 4.3.5-0.1 build . will be re-tested later

Comment 5 Polina 2019-06-18 11:12:18 UTC

yes, thank you . I see that patch tagged ovirt-engine-4.3.5.1 . 
we only have 4.3.5-0.1 build . will be re-tested later

Comment 6 Polina 2019-06-24 08:22:21 UTC

tested on ovirt-engine-4.3.5.1-0.1.el7.noarch

Editing the pool with a change of template to subversion returns now "Cannot change the VM Template when the VMs created are set to Delete Protected."

Comment 7 Sandro Bonazzola 2019-07-30 14:08:15 UTC

This bugzilla is included in oVirt 4.3.5 release, published on July 30th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.