Bug 1720223

Summary: appliance_console: After configuring the "Logfile Configuration" and then running "Harden Appliance Using SCAP Configuration", the old filesystem is not removed from fstab
Product: Red Hat CloudForms Management Engine Reporter: Raul Mahiques <rmahique>
Component: ApplianceAssignee: Brandon Dunne <bdunne>
Status: CLOSED CURRENTRELEASE QA Contact: Md Nadeem <mnadeem>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.5CC: abellott, dmetzger, nansari, obarenbo, rchincho, simaishi, yrudman
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.14 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1728270 (view as bug list) Environment:
Last Closed: 2019-12-13 15:00:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1728270    

Description Raul Mahiques 2019-06-13 12:34:32 UTC
Description of problem:
appliance_console: After configuring the "Logfile Configuration" and then running "Harden Appliance Using SCAP Configuration", the newly created filesystem is removed from fstab, therefore after a reboot all the log files 'dissapear' as it mounts the old FS.

Version-Release number of selected component (if applicable):
Seen on 5.10.5, maybe in older versions too.

How reproducible:
Always

Steps to Reproduce:
As described in the description of the problem

Actual results:
FS is removed from fstab


Expected results:
FS remains in fstab

Additional info:

Comment 2 Raul Mahiques 2019-06-13 13:24:24 UTC
Correction, it doesn't remove the entry in fstab, and probably has nothing to do with SCAP
It just don't remove the old entry, so when the system reboots it mounts the old one.

Comment 3 Brandon Dunne 2019-07-01 13:58:38 UTC
Hi Raul,

What entry is not removed from fstab that you were expecting to be removed?  While testing this myself, the only change that I saw was the additional entry for the log filesystem when configuring "Logfile Configuration".  Nothing seemed to change between reboots.

Comment 4 Raul Mahiques 2019-07-01 16:06:05 UTC
(In reply to Brandon Dunne from comment #3)
> Hi Raul,
> 
> What entry is not removed from fstab that you were expecting to be removed? 
> While testing this myself, the only change that I saw was the additional
> entry for the log filesystem when configuring "Logfile Configuration". 
> Nothing seemed to change between reboots.

See my last comment, it wasn't being removed from fstab, what happens is that when rebooting it just mounts the old filesystem.

What should happen is this:
- User specifies a partition/disk or a new logical volume.
    case "disk"
       create a new partition with the desired size
       format the partition as a physical volume (PV)
       add this PV to the volume group (VG)
       move the existing logical volume(LV) to the new PV
       Extend the LV to the desired space.
    case "partition"
       format the partition as a physical volume (PV)
       add this PV to the volume group (VG)
       move the existing logical volume(LV) to the new PV
       Extend the LV to the desired space.
    case "logical volume"
       mount the logical volume into a temporary folder and move the data over.
       change fstab to replace the source for the mount point with the new logical volume.
       remove old logical volume

Comment 6 CFME Bot 2019-07-08 22:02:25 UTC
New commits detected on ManageIQ/manageiq-appliance_console/master:

https://github.com/ManageIQ/manageiq-appliance_console/commit/4a71c98e47d40397d1fb3c37e840a1c0e7b33cad
commit 4a71c98e47d40397d1fb3c37e840a1c0e7b33cad
Author:     Brandon Dunne <brandondunne>
AuthorDate: Fri Jul  5 18:25:53 2019 -0400
Commit:     Brandon Dunne <brandondunne>
CommitDate: Fri Jul  5 18:25:53 2019 -0400

    mount_point is a Pathname, but needs to match a string

    https://bugzilla.redhat.com/show_bug.cgi?id=1720223

 lib/manageiq/appliance_console/logical_volume_management.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


https://github.com/ManageIQ/manageiq-appliance_console/commit/64f34cededd5ddfcaf7f839d8873fc5beee38ce4
commit 64f34cededd5ddfcaf7f839d8873fc5beee38ce4
Author:     Brandon Dunne <brandondunne>
AuthorDate: Fri Jul  5 18:27:30 2019 -0400
Commit:     Brandon Dunne <brandondunne>
CommitDate: Fri Jul  5 18:27:30 2019 -0400

    Unmount the mount point before mounting if it is already mounted

    https://bugzilla.redhat.com/show_bug.cgi?id=1720223

 lib/manageiq/appliance_console/logical_volume_management.rb | 5 +
 1 file changed, 5 insertions(+)

Comment 8 CFME Bot 2019-07-09 13:36:25 UTC
New commit detected on ManageIQ/manageiq-appliance/master:

https://github.com/ManageIQ/manageiq-appliance/commit/818fac66d792e924a09a4be25db254d7f57187f8
commit 818fac66d792e924a09a4be25db254d7f57187f8
Author:     Brandon Dunne <brandondunne>
AuthorDate: Mon Jul  8 18:21:32 2019 -0400
Commit:     Brandon Dunne <brandondunne>
CommitDate: Mon Jul  8 18:21:32 2019 -0400

    Update dependency on manageiq-appliance_console

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720223
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1716404

 manageiq-appliance-dependencies.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)